Remove m_glContextInitialized, simplify updateScreen - #725
Open
mcarans wants to merge 3 commits into
Open
Conversation
mcarans
requested review from
AnotherCommander,
Kaks,
KonstantinosSykas,
dsalt,
ericwalch,
jobi-wan,
kanthoney,
mwerle,
oocube and
phkb
as code owners
August 23, 2026 05:18
mcarans
marked this pull request as draft
August 23, 2026 23:29
Contributor
Author
|
Setting to draft while I investigate failure on master |
mcarans
force-pushed
the
further_simplify
branch
from
August 24, 2026 19:21
0c3f9d0 to
f72129b
Compare
Contributor
Author
|
@phkb @LW-archlinux I have rebased this with the fix (the revert) merged into master. Please let me know if it works for you. |
mcarans
marked this pull request as ready for review
August 24, 2026 19:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@phkb @LW-archlinux If this works but not #726, then I'll merge this otherwise I'll merge 726 instead as it is a superset of this.