Skip to content

fix(web): tables let the page scroll, and a user row opens the sheet #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ripgrim merged 1 commit into from
Oct 24, 2026
Merged

fix(web): tables let the page scroll, and a user row opens the sheet #92

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion apps/web/src/components/admin/admin-users-page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -400,7 +400,23 @@ export function AdminUsersPage() {
/>
) : (
users.map((u) => (
<TableRow key={u.id} selected={selected.includes(u.id)}>
<TableRow
className="cursor-pointer"
key={u.id}
onClick={(event) => {
if (
event.target instanceof Element &&
event.target.closest(
"button, a, input, label, [role='checkbox'], [role='switch'], [role='menuitem']",
)
) {
return;
}
openUser(u.id);
}}
open={u.id === openUserId}
selected={selected.includes(u.id)}
>
<TableCell>
<Checkbox
aria-label={`Select ${u.name}`}
Expand Down
2 changes: 1 addition & 1 deletion apps/web/src/components/glaze/ui/table.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ function Table({className, frame = 'card', title, count, actions, toolbar, foote
role={tab === 0 && (name || labelledBy) ? 'region' : undefined}
aria-label={tab === 0 && name ? name : undefined}
aria-labelledby={tab === 0 ? labelledBy : undefined}
className={cn('group/table relative w-full min-w-0 overflow-auto overscroll-contain focus-visible:focus-ring-inset', containerClassName)}
className={cn('group/table relative w-full min-w-0 overflow-auto overscroll-x-contain focus-visible:focus-ring-inset', containerClassName)}
// value-ok: the scroll box's height is the caller's, a number of px or any length, so it can only live inline.
style={maxHeight !== undefined ? {maxHeight} : undefined}
>
Expand Down
Loading