Skip to content

Report effective bulk command permissions - #1604

Merged
BenCodez merged 2 commits into
masterfrom
codex/player-all-perms-report
Sep 10, 2026
Merged

Report effective bulk command permissions#1604
BenCodez merged 2 commits into
masterfrom
codex/player-all-perms-report

Conversation

@BenCodez

@BenCodez BenCodez commented Sep 10, 2026

Copy link
Copy Markdown
Owner

Summary

  • derive /av perms bulk entries from AdvancedCore PlayerCommandHandler metadata for both /vote and /av handlers
  • show each ordinary permission with a labelled additional all-target permission and effective access for the inspected player
  • register bulk nodes as default-false without making them children of ordinary permissions
  • preserve the negative bulk AddPoints safeguard and apply the existing administrator-override policy consistently

Examples include VotingPlugin.Commands.AdminVote.SetPoints.All, VotingPlugin.Commands.AdminVote.AddPoints.All, and VotingPlugin.Commands.AdminVote.RemovePoints.All. Base-only staff retain named-player access but require the matching .All node for bulk actions; VotingPlugin.Admin remains the configured full-admin override when multiple-permission checks are enabled.

Depends on and is coordinated with AdvancedCore #316.

Validation

  • built AdvancedCore Single command for vote party #316 into isolated Maven repository /root/.cache/codex-m2/player-all-permissions/repository
  • mvn -o -B -Dmaven.repo.local=/root/.cache/codex-m2/player-all-permissions/repository clean package (619 tests, 0 failures/errors; BUILD SUCCESS; shaded JAR)
  • verified the shaded VotingPlugin JAR contains the relocated AdvancedCore PlayerCommandHandler APIs runCommand, hasAllPermission, getAdditionalPermissions, and withAllPermissionOverrides
  • git diff --check
  • independent final review: No findings

Coverage includes sender, named-player, console, pagination, developer output, multiple handlers, admin-policy modes, wrong/base-only permissions, dynamic registration, and negative AddPoints.

Ordering

Merge and publish AdvancedCore #316 first, then update/build this PR against that released artifact before merging. No deployment is included.

AI assistance was used for implementation and review; the complete diff was independently source-reviewed and validated locally.

Compatibility note: the source compiles against the currently published snapshot so pre-release CI can run, but command registration fails closed at runtime if the secure AdvancedCore #316 bulk API is absent. Deployment therefore requires #316 first. Final candidate JAR SHA-256: 3988ce70ad034785a12dcfbcdd939c6857e20fbfe7f6453fd6b180a00c4cf092.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 10, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-10T15:48:35.865413Z 5d29a7c Manual request
🔒 Security Review Completed 2026-09-10T04:09:59.901855Z 6472e66 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@BenCodez

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Nice work!

Reviewed commit: 5d29a7cee2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@BenCodez

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Can't wait for the next one!

Reviewed commit: 5d29a7cee2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@BenCodez

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 🎉

Reviewed commit: 5d29a7cee2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@BenCodez

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. What shall we delve into next?

Reviewed commit: 5d29a7cee2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@BenCodez
BenCodez merged commit 222b38a into master Sep 10, 2026
4 checks passed
@BenCodez
BenCodez deleted the codex/player-all-perms-report branch September 10, 2026 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant