Skip to content

Enforce per-command permissions for bulk player actions - #316

Merged
BenCodez merged 4 commits into
masterfrom
codex/player-all-permissions
Sep 10, 2026
Merged

Enforce per-command permissions for bulk player actions#316
BenCodez merged 4 commits into
masterfrom
codex/player-all-permissions

Conversation

@BenCodez

@BenCodez BenCodez commented Sep 10, 2026

Copy link
Copy Markdown
Owner

Summary

  • enforce each PlayerCommandHandler normal permission plus its derived granular .All permission before executeAll
  • keep configured administrator overrides subject to the existing multiple-permission-check policy
  • expose enforced bulk permission metadata through getAdditionalPermissions and hasAllPermission
  • harden dispatch for case-insensitive ALL, short arguments, schema changes, and SimpleAPI player-name normalization

Examples include VotingPlugin.Commands.AdminVote.SetPoints.All and VotingPlugin.Commands.AdminVote.RemovePoints.All. Base-only staff retain named-player access but must receive the matching .All node for bulk access. The former SetAllData compatibility route now follows the shared SetData plus SetData.All contract.

Validation

  • mvn -B -Dmaven.repo.local=/root/.cache/codex-m2/player-all-permissions/repository clean test-compile org.apache.maven.plugins:maven-surefire-plugin:3.5.4:test (300 tests, 0 failures/errors)
  • mvn -B -Dmaven.repo.local=/root/.cache/codex-m2/player-all-permissions/repository -DskipTests clean install (BUILD SUCCESS; shaded JAR)
  • git diff --check
  • independent final review: No findings

AdvancedCore uses legacy Surefire 2.17 by default, so JUnit 5 validation uses Surefire 3.5.4 explicitly before the clean install.

Ordering

Merge and publish this AdvancedCore artifact before the coordinated VotingPlugin permission-reporting PR. Do not deploy either change independently until the dependency is available.

AI assistance was used for implementation and review; the full diff was independently source-reviewed and validated locally.

Coordinated consumer PR: BenCodez/VotingPlugin#1604.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 10, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-10T16:10:40.272629Z 61f18e5 New commits
🔒 Security Review Completed 2026-09-10T04:09:39.683947Z 75673dd PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 75673dd418

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@BenCodez

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5d68c10ded

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 05d58fdfad

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@BenCodez
BenCodez merged commit d0ea30b into master Sep 10, 2026
4 checks passed
@BenCodez
BenCodez deleted the codex/player-all-permissions branch September 10, 2026 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant