Enforce per-command permissions for bulk player actions - #316
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 75673dd418
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5d68c10ded
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 05d58fdfad
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Summary
Examples include VotingPlugin.Commands.AdminVote.SetPoints.All and VotingPlugin.Commands.AdminVote.RemovePoints.All. Base-only staff retain named-player access but must receive the matching .All node for bulk access. The former SetAllData compatibility route now follows the shared SetData plus SetData.All contract.
Validation
AdvancedCore uses legacy Surefire 2.17 by default, so JUnit 5 validation uses Surefire 3.5.4 explicitly before the clean install.
Ordering
Merge and publish this AdvancedCore artifact before the coordinated VotingPlugin permission-reporting PR. Do not deploy either change independently until the dependency is available.
AI assistance was used for implementation and review; the full diff was independently source-reviewed and validated locally.
Coordinated consumer PR: BenCodez/VotingPlugin#1604.