Repository navigation
Fix matrix products in LQR discrete Riccati solver - #1483
Open
huxiaoyi-ovo wants to merge 3 commits into
Open
huxiaoyi-ovo wants to merge 3 commits into
huxiaoyi-ovo wants to merge 3 commits into
Conversation
huxiaoyi-ovo
marked this pull request as ready for review
October 29, 2026 07:19
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
LQRPlanner.solve_dare()iteration implements the discrete algebraic Riccati equation using NumPy*(elementwise multiplication) where the equation requires matrix products.For the planner's default system matrices with
Q=IandR=I:solve_discrete_aredown to approximately 1.65e-7 at the planner's default iteration tolerance.Changes
@matrix products rather than*.scipy.linalg.solveinstead of an explicit inverse in the Riccati correction term.Regression tests
Two new tests compare against SciPy's standard
solve_discrete_arereference:Only two files changed, with no new dependencies.
Independent cross-platform CI validation has been started; verification results will follow.
AI disclosure: ChatGPT assisted with the analysis, fix, and regression tests.