Repository navigation
Fix PRM collision checks to account for the full edge - #1482
Open
huxiaoyi-ovo wants to merge 4 commits into
Open
huxiaoyi-ovo wants to merge 4 commits into
huxiaoyi-ovo wants to merge 4 commits into
Conversation
huxiaoyi-ovo
marked this pull request as ready for review
October 29, 2026 06:29
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The PRM planner currently checks collision only at points spaced by the robot radius. It can therefore accept an edge that intersects an obstacle's clearance disk.
For example, an edge from
(0, 0)to(1, 0), with robot radius1.0and an obstacle at(0.5, 0.95), has a true clearance of0.95. The current code checks only the endpoints, both about1.074away, and incorrectly returnsFalse(no collision).The same function divides by the robot radius, causing a
ZeroDivisionErrorfor a point robot (rr=0).Fix
MAX_EDGE_LENconstraint andis_collisionAPI.Validation
The added regression tests cover a collision missed between discrete samples, noncolliding clearance, a point robot with obstacles on/off the edge, a zero-length segment, and obstacles beyond the endpoint. Eight direct geometry checks passed, including an empty-obstacle KDTree.
Full Linux, macOS, Windows, and CodeQL validation is running in fork CI PR #5.
Changes: two files; no new dependencies.
AI disclosure: ChatGPT assisted with code analysis, implementation, and test preparation.