Repository navigation
Exclude unwritten capacity from trajectory extraction - #921
Merged
david-zwicker merged 1 commit intoOct 20, 2026
Merged
david-zwicker merged 1 commit into
david-zwicker merged 1 commit into
Conversation
- Limit time searches and component extraction to stored frames. - Cover partial, full and extensible HDF files and scalar/vector components.
antonsoo
force-pushed
the
fix/preallocated-trajectory-extraction
branch
from
October 19, 2026 18:56
724109c to
b4b4aad
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracting a trajectory from a partially filled preallocated file includes unwritten frames. Time-range searches also use the padded timestamps, which need not be sorted. For example:
Limit time searches and component extraction to
len(storage). The HDF datasets keep their existing lazy access and allocated capacity.The regression covers partial, full and extensible files, compressed and uncompressed storage, time bounds, and scalar/vector component copies. Native stopped diffusion and wave trajectories also agree with independently copied callback snapshots; existing correct results and solver states stay unchanged.
File-storage tests, the storage/tracker/diffusion/wave checks, and project hooks pass. Whole-project Mypy reports the same diagnostics as unchanged upstream.
Rebased after #922 merged, retaining its complete storage-finalization regressions. The updated branch passes 166 storage, tracker, diffusion and wave tests (26 optional skips) and all configured hooks. All 576 extraction records and all 100 close/resume records remain exactly equal to the previously validated composition, including the independent callback/Fourier references and solver controls. Mypy still reports the same 169 baseline diagnostics.