Repository navigation
test(graphql): cover custom websocket handshake headers #1026 - #1534
Open
AzazelSensei wants to merge 1 commit into
Open
AzazelSensei wants to merge 1 commit into
AzazelSensei wants to merge 1 commit into
Conversation
SocketClient already takes custom headers, but the echo mock dropped the HTTP upgrade so we never asserted them. Keep handshake headers on the mock and check that myHeader is sent. Fixes zino-hofmann#1026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1534 +/- ##
=======================================
Coverage 65.83% 65.83%
=======================================
Files 43 43
Lines 2096 2096
=======================================
Hits 1380 1380
Misses 716 716
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SocketClient already accepts custom headers, but we never checked that they actually go out on the handshake.
I changed the echo mock so it keeps the HTTP upgrade headers, then added a test that
myHeaderis present. That was the leftover FIXME inwebsocket_test.dart.Fixes #1026