Skip to content

d_a_obj_mushroom - #345

Merged
elijah-thomas774 merged 3 commits into
zeldaret:mainfrom
elijah-thomas774:d_a_obj_mushroom
Oct 3, 2026
Merged

d_a_obj_mushroom#345
elijah-thomas774 merged 3 commits into
zeldaret:mainfrom
elijah-thomas774:d_a_obj_mushroom

Conversation

@elijah-thomas774

@elijah-thomas774 elijah-thomas774 commented Sep 26, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@decomp-dev

decomp-dev Bot commented Sep 26, 2026 •
edited
Loading

Copy link
Copy Markdown

Report for SOUE01 (aec7b6f - de0fcc2)

📈 Matched code: 26.45% (+0.07%, +8640 bytes)
📈 Matched data: 15.10% (+0.03%, +928 bytes)

✅ 42 new matches
Unit Item Bytes Before After
d_a_obj_mushroomNP/REL/d/a/obj/d_a_obj_mushroom dAcOMushRoom_c::proc_c::drawOpa() +1260 0.00% 100.00%
d_a_obj_mushroomNP/REL/d/a/obj/d_a_obj_mushroom .data +913 1.72% 100.00%
d_a_obj_mushroomNP/REL/d/a/obj/d_a_obj_mushroom dAcOMushRoom_c::draw() +704 0.00% 100.00%
d_a_obj_mushroomNP/REL/d/a/obj/d_a_obj_mushroom dAcOMushRoom_c::fn_328_3970() +560 0.00% 100.00%
d_a_obj_mushroomNP/REL/d/a/obj/d_a_obj_mushroom dAcOMushRoom_c::initCc() +520 0.00% 100.00%
d_a_obj_mushroomNP/REL/d/a/obj/d_a_obj_mushroom dAcOMushRoom_c::actorExecute() +460 0.00% 100.00%
d_a_obj_mushroomNP/REL/d/a/obj/d_a_obj_mushroom dAcOMushRoom_c::createHeap() +404 0.00% 100.00%
d_a_obj_mushroomNP/REL/d/a/obj/d_a_obj_mushroom dAcOMushRoom_c_classInit() +287 36.05% 100.00%
d_a_obj_mushroomNP/REL/d/a/obj/d_a_obj_mushroom dAcOMushRoom_c::fn_328_4B20(const mMtx_c&, const mVec3_c&, float, float) +264 0.00% 100.00%
d_a_obj_mushroomNP/REL/d/a/obj/d_a_obj_mushroom dAcOMushRoom_c::doDelete() +252 0.00% 100.00%
d_a_obj_mushroomNP/REL/d/a/obj/d_a_obj_mushroom dAcOMushRoom_c::getDataBinName() +248 0.00% 100.00%
d_a_obj_mushroomNP/REL/d/a/obj/d_a_obj_mushroom dAcOMushRoom_c::proc_c::create(EGG::ResTIMG*, unsigned long, mAllocator_c*, long, mVec3_c*, mVec3_c*, unsigned short*, unsigned short*) +232 0.00% 100.00%
d_a_obj_mushroomNP/REL/d/a/obj/d_a_obj_mushroom dAcOMushRoom_c::~dAcOMushRoom_c() +220 46.15% 100.00%
d_a_obj_mushroomNP/REL/d/a/obj/d_a_obj_mushroom dAcOMushRoom_c::setLighting() +204 0.00% 100.00%
d_a_obj_mushroomNP/REL/d/a/obj/d_a_obj_mushroom dAcOMushRoom_c::getRadiusZ() +196 0.00% 100.00%
d_a_obj_mushroomNP/REL/d/a/obj/d_a_obj_mushroom dAcOMushRoom_c::fn_328_4EF0() +192 0.00% 100.00%
d_a_obj_mushroomNP/REL/d/a/obj/d_a_obj_mushroom dAcOMushRoom_c::getUnscaledRadiusY() +188 0.00% 100.00%
d_a_obj_mushroomNP/REL/d/a/obj/d_a_obj_mushroom dAcOMushRoom_c::getUnscaledRadiusX() +184 0.00% 100.00%
d_a_obj_mushroomNP/REL/d/a/obj/d_a_obj_mushroom dAcOMushRoom_c::getResFileName() +176 0.00% 100.00%
d_a_obj_mushroomNP/REL/d/a/obj/d_a_obj_mushroom dAcOMushRoom_c::proc_c::draw() +176 0.00% 100.00%
d_a_obj_mushroomNP/REL/d/a/obj/d_a_obj_mushroom int cM::rndRange<int>(int, int) +136 0.00% 100.00%
d_a_obj_mushroomNP/REL/d/a/obj/d_a_obj_mushroom dAcOMushRoom_c::checkUnderWater() +132 0.00% 100.00%
d_a_obj_mushroomNP/REL/d/a/obj/d_a_obj_mushroom dLOD_c::mdl_c::~mdl_c() +128 0.00% 100.00%
d_a_obj_mushroomNP/REL/d/a/obj/d_a_obj_mushroom dAcOMushRoom_c::proc_c::~proc_c() +124 0.00% 100.00%
d_a_obj_mushroomNP/REL/d/a/obj/d_a_obj_mushroom dMdlLOD_c::~dMdlLOD_c() +120 0.00% 100.00%
d_a_obj_mushroomNP/REL/d/a/obj/d_a_obj_mushroom dAcOMushRoom_c::camera_c::camera_c() +104 0.00% 100.00%
d_a_obj_mushroomNP/REL/d/a/obj/d_a_obj_mushroom dAcOMushRoom_c::camera_c::~camera_c() +100 0.00% 100.00%
d_a_obj_mushroomNP/REL/d/a/obj/d_a_obj_mushroom dAcOMushRoom_c::proc_c::proc_c() +92 0.00% 100.00%
d_a_obj_mushroomNP/REL/d/a/obj/d_a_obj_mushroom dShadowCircle_c::~dShadowCircle_c() +88 0.00% 100.00%
d_a_obj_mushroomNP/REL/d/a/obj/d_a_obj_mushroom dAcOMushRoom_c::initializeState_Wait() +76 5.00% 100.00%

...and 12 more new matches

📈 11 improvements in unmatched items
Unit Item Bytes Before After
d_a_obj_mushroomNP/REL/d/a/obj/d_a_obj_mushroom dAcOMushRoom_c::executeState_Wait() +3405 0.12% 99.34%
d_a_obj_mushroomNP/REL/d/a/obj/d_a_obj_mushroom dAcOMushRoom_c::startCloudEmitter() +1896 0.00% 99.83%
d_a_obj_mushroomNP/REL/d/a/obj/d_a_obj_mushroom dAcOMushRoom_c::fn_328_39C0() +1790 0.00% 97.54%
d_a_obj_mushroomNP/REL/d/a/obj/d_a_obj_mushroom dAcOMushRoom_c::create() +1055 0.00% 99.58%
d_a_obj_mushroomNP/REL/d/a/obj/d_a_obj_mushroom dAcOMushRoom_c::updateCameras() +840 0.00% 99.15%
d_a_obj_mushroomNP/REL/d/a/obj/d_a_obj_mushroom dAcOMushRoom_c::startGlitterEmitter() +766 0.00% 98.26%
d_a_obj_mushroomNP/REL/d/a/obj/d_a_obj_mushroom dAcOMushRoom_c::setCc() +547 0.00% 99.99%
d_a_obj_mushroomNP/REL/d/a/obj/d_a_obj_mushroom fn_328_830(signed char, signed char) +444 0.00% 98.30%
d_a_obj_mushroomNP/REL/d/a/obj/d_a_obj_mushroom dAcOMushRoom_c::fn_328_4C30(const float&, const short&, cCcD_Obj*, const float&, const float&) +381 0.00% 92.66%
d_a_obj_mushroomNP/REL/d/a/obj/d_a_obj_mushroom .rodata +359 0.00% 96.67%
d_a_obj_mushroomNP/REL/d/a/obj/d_a_obj_mushroom __sinit_\d_a_obj_mushroom_cpp +176 68.34% 96.77%

@elijah-thomas774
elijah-thomas774 force-pushed the d_a_obj_mushroom branch 3 times, most recently from 45d8603 to af6693c Compare September 26, 2026 18:47
@elijah-thomas774
elijah-thomas774 marked this pull request as ready for review September 27, 2026 02:29
elijah-thomas774
elijah-thomas774 commented Sep 27, 2026
View reviewed changes

@elijah-thomas774 elijah-thomas774 left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quite a few issues with this one...

Im going to stop here before I get burnt out

@elijah-thomas774

elijah-thomas774 commented Sep 30, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator Author

Waiting on #347 for rebase to isolate changes resolved

@elijah-thomas774
elijah-thomas774 merged commit 98aba2c into zeldaret:main Oct 3, 2026
1 check passed
@elijah-thomas774
elijah-thomas774 deleted the d_a_obj_mushroom branch October 3, 2026 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@robojumper robojumper robojumper approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@elijah-thomas774 @robojumper