Skip to content

Import JStudio from TP - #326

Open
robojumper wants to merge 6 commits into
zeldaret:mainfrom
robojumper:import-jstudio-base
Open

robojumper wants to merge 6 commits into
zeldaret:mainfrom
robojumper:import-jstudio-base

Conversation

@robojumper

Copy link
Copy Markdown
Collaborator

Based on #325.

This is only the base JStudio lib (and JGadget). These ones have received very few changes and largely match out of the box (a few nonmatchings remain).

TODO: JStage, JStudio_JStage, JStudio_JAudio2, JStudio_JParticle. These have received significantly larger changes and will need some attention to detail, so a separate PR

@decomp-dev

decomp-dev Bot commented May 31, 2026 •

Copy link
Copy Markdown

Report for SOUE01 (9481f3a - 0b51d1b)

📈 Matched code: 26.21% (+0.23%, +28552 bytes)
📈 Linked code: 15.53% (+0.05%, +6172 bytes)
📈 Matched data: 14.90% (+0.02%, +508 bytes)
📈 Linked data: 25.68% (+0.01%, +248 bytes)

✅ 272 new matches
Unit Item Bytes Before After
main/JSystem/JStudio/JStudio/functionvalue JStudio::TFunctionValue_hermite::getValue(double) +968 0.00% 100.00%
main/JSystem/JStudio/JStudio/functionvalue JStudio::TFunctionValue_list::getValue(double) +940 0.00% 100.00%
main/JSystem/JStudio/JStudio/jstudio-object JStudio::TObject_actor::do_paragraph(unsigned long, const void*, unsigned long) +880 0.00% 100.00%
main/JSystem/JStudio/JStudio/jstudio-object JStudio::TObject_sound::do_paragraph(unsigned long, const void*, unsigned long) +880 0.00% 100.00%
main/JSystem/JStudio/JStudio/functionvalue JStudio::TFunctionValueAttribute_range::range_getParameter(double, double, double) const +780 0.00% 100.00%
main/JSystem/JStudio/JStudio/jstudio-object JStudio::TObject_camera::do_paragraph(unsigned long, const void*, unsigned long) +712 0.00% 100.00%
main/JSystem/JStudio/JStudio/fvb JStudio::fvb::TObject::prepare(const JStudio::fvb::data::TParse_TBlock&, JStudio::fvb::TControl*) +556 0.00% 100.00%
main/JSystem/JStudio/JStudio/stb JStudio::stb::TObject::forward(unsigned long) +532 0.00% 100.00%
main/JSystem/JStudio/JStudio/functionvalue JStudio::TFunctionValue_list_parameter::update_INTERPOLATE_BSPLINE_dataMore3_(const JStudio::TFunctionValue_list_parameter&, double) +528 0.00% 100.00%
main/JSystem/JStudio/JStudio/functionvalue JStudio::TFunctionValue_list_parameter::getValue(double) +516 0.00% 100.00%
main/JSystem/JStudio/JStudio/jstudio-object JStudio::TAdaptor::adaptor_getVariableValue_GXColor(_GXColor*, const unsigned long*) const +456 0.00% 100.00%
main/JSystem/JStudio/JStudio/functionvalue JStudio::TFunctionValue_transition::getValue(double) +448 0.00% 100.00%
main/JSystem/JStudio/JStudio/functionvalue JStudio::TFunctionValue_composite::composite_index(const JGadget::TVector_pointer<JStudio::TFunctionValue*>&, const JStudio::TFunctionValue_composite::TData&, double) +364 0.00% 100.00%
main/JSystem/JStudio/JStudio/jstudio-math JStudio::math::getRotation_xyz(float(*)[4], float, float, float) +364 0.00% 100.00%
main/JSystem/JStudio/JStudio/stb JStudio::stb::TObject::process_sequence_() +308 0.00% 100.00%
main/JSystem/JStudio/JStudio/stb JStudio::stb::TParse::parseBlock_object(const JStudio::stb::data::TParse_TBlock_object&, unsigned long) +276 0.00% 100.00%
main/JSystem/JStudio/JStudio/fvb JStudio::fvb::TFactory::create(const JStudio::fvb::data::TParse_TBlock&) +272 0.00% 100.00%
main/JSystem/JGadget/binary JGadget::binary::TParse_header_block::parse_next(const void**, unsigned long) +268 0.00% 100.00%
main/JSystem/JStudio/JStudio/fvb JStudio::fvb::TParse::parseBlock_next(const void**, unsigned long*, unsigned long) +252 0.00% 100.00%
main/JSystem/JStudio/JStudio/jstudio-control JStudio::TParse::parseBlock_block_ctb_(const JStudio::stb::data::TParse_TBlock&, unsigned long) +252 0.00% 100.00%
main/JSystem/JStudio/JStudio/functionvalue JStudio::functionvalue::interpolateValue_BSpline_nonuniform(double, const double*, const double*) +248 0.00% 100.00%
main/JSystem/JStudio/JStudio/ctb JStudio::ctb::TParse::parseBlock_next(const void**, unsigned long*, unsigned long) +228 0.00% 100.00%
main/JSystem/JStudio/JStudio/object-id JStudio::object::TIDData::isEqual(const JStudio::object::TIDData&, const JStudio::object::TIDData&) +228 0.00% 100.00%
main/JSystem/JStudio/JStudio/functionvalue .data +224 0.00% 100.00%
main/JSystem/JStudio/JStudio/jstudio-object JStudio::TAdaptor::adaptor_setVariableValue_n(JStudio::TControl*, const unsigned long*, unsigned long, JStudio::data::TEOperationData, const void*, unsigned long) +224 0.00% 100.00%
main/JSystem/JStudio/JStudio/stb JStudio::stb::TParse::parseHeader_next(const void**, unsigned long*, unsigned long) +208 0.00% 100.00%
main/JSystem/JStudio/JStudio/stb JStudio::stb::TControl::forward(unsigned long) +200 0.00% 100.00%
main/JSystem/JStudio/JStudio/stb JStudio::stb::TObject::process_paragraph_reserved_(unsigned long, const void*, unsigned long) +192 0.00% 100.00%
main/JSystem/JGadget/std-vector JGadget::TVector_pointer_void::~TVector_pointer_void() +180 0.00% 100.00%
main/JSystem/JStudio/JStudio/jstudio-control JStudio::TParse::parseBlock_block_fvb_(const JStudio::stb::data::TParse_TBlock&, unsigned long) +172 0.00% 100.00%

...and 242 more new matches

📈 29 improvements in unmatched items
Unit Item Bytes Before After
main/JSystem/JGadget/std-vector JGadget::TVector_pointer_void::insert(void**, void* const&) +1427 0.00% 99.94%
main/JSystem/JGadget/std-vector JGadget::TVector_pointer_void::TVector_pointer_void(unsigned long, void* const&, const JGadget::TAllocator<void*>&) +1177 0.00% 83.38%
main/JSystem/JStudio/JStudio/jstudio-object JStudio::TObject_particle::do_paragraph(unsigned long, const void*, unsigned long) +943 0.00% 99.16%
main/JSystem/JStudio/JStudio/jstudio-object __sinit_\jstudio-object_cpp +766 0.00% 99.86%
main/JSystem/JStudio/JStudio/jstudio-object JStudio::TObject_light::do_paragraph(unsigned long, const void*, unsigned long) +508 0.00% 93.38%
main/JSystem/JStudio/JStudio/jstudio-object .data +415 0.00% 16.67%
main/JSystem/JStudio/JStudio/jstudio-object .rodata +285 0.00% 99.30%
main/JSystem/JStudio/JStudio/jstudio-math JStudio::math::getFromTransformation_SRxyzT(Vec*, Vec*, Vec*, const float(*)[4]) +259 0.00% 36.26%
main/JSystem/JStudio/JStudio/functionvalue JStudio::TFunctionValue_composite::composite_subtract(const JGadget::TVector_pointer<JStudio::TFunctionValue*>&, const JStudio::TFunctionValue_composite::TData&, double) +227 0.00% 98.00%
main/JSystem/JStudio/JStudio/functionvalue JStudio::TFunctionValue_composite::composite_divide(const JGadget::TVector_pointer<JStudio::TFunctionValue*>&, const JStudio::TFunctionValue_composite::TData&, double) +227 0.00% 98.00%
main/JSystem/JStudio/JStudio/jstudio-object .bss +208 0.00% 50.00%
main/JSystem/JStudio/JStudio/jstudio-object JStudio::TObject_fog::do_paragraph(unsigned long, const void*, unsigned long) +202 0.00% 99.31%
main/JSystem/JStudio/JStudio/jstudio-control JStudio::TParse::parseHeader(const JStudio::stb::data::TParse_THeader&, unsigned long) +194 0.00% 93.56%
main/JSystem/JStudio/JStudio/jstudio-object JStudio::TObject_ambientLight::do_paragraph(unsigned long, const void*, unsigned long) +190 0.00% 99.27%
main/JSystem/JStudio/JStudio/jstudio-control JStudio::TControl::transform_setOrigin_ctb(const JStudio::ctb::TObject&) +159 0.00% 90.91%
main/JSystem/JStudio/JStudio/fvb .data +148 0.00% 61.67%
main/JSystem/JStudio/JStudio/functionvalue JStudio::TFunctionValue_composite::composite_add(const JGadget::TVector_pointer<JStudio::TFunctionValue*>&, const JStudio::TFunctionValue_composite::TData&, double) +131 0.00% 96.59%
main/JSystem/JStudio/JStudio/functionvalue JStudio::TFunctionValue_composite::composite_multiply(const JGadget::TVector_pointer<JStudio::TFunctionValue*>&, const JStudio::TFunctionValue_composite::TData&, double) +131 0.00% 96.59%
main/JSystem/JStudio/JStudio/stb .data +108 0.00% 96.43%
main/JSystem/JStudio/JStudio/functionvalue JStudio::TFunctionValue_composite::composite_parameter(const JGadget::TVector_pointer<JStudio::TFunctionValue*>&, const JStudio::TFunctionValue_composite::TData&, double) +103 0.00% 95.70%
main/JSystem/JStudio/JStudio/fvb JStudio::fvb::TObject_composite::prepare_data_(const JStudio::fvb::data::TParse_TParagraph::TData&, JStudio::fvb::TControl*) +92 0.00% 82.96%
main/JSystem/JStudio/JStudio/ctb .data +67 0.00% 94.44%
main/JSystem/JStudio/JStudio/functionvalue JStudio::TFunctionValue_composite::initialize() +51 0.00% 71.28%
main/JSystem/JStudio/JStudio/jstudio-object .sdata2 +37 0.00% 94.74%
main/JSystem/JStudio/JStudio/jstudio-math .sdata2 +13 0.00% 41.67%
main/JSystem/JStudio/JStudio/ctb-data .sdata2 +5 0.00% 66.67%
main/JSystem/JStudio/JStudio/fvb-data .sdata2 +5 0.00% 66.67%
main/JSystem/JStudio/JStudio/stb-data .sdata2 +5 0.00% 66.67%
main/JSystem/JStudio/JStudio/jstudio-object .sbss +4 0.00% 50.00%

@robojumper
robojumper force-pushed the import-jstudio-base branch 3 times, most recently from 62a5e2d to 637dfa4 Compare May 31, 2026 16:10
@robojumper
robojumper force-pushed the import-jstudio-base branch from 637dfa4 to 17c163d Compare May 31, 2026 16:20
@elijah-thomas774

Copy link
Copy Markdown
Collaborator

Since this has been sitting - I’ll chip away at some of this here and seeing if I can make small bits of progress in it.

@elijah-thomas774

Copy link
Copy Markdown
Collaborator

@robojumper - Can you take a quick look at the changes I did?
We can merge after approval

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants