Skip to content

Remove src/ from include path and consider src/ includes in includes style - #2823

Merged
Dragorn421 merged 3 commits into
zeldaret:mainfrom
Dragorn421:rm_inc_src
Sep 17, 2026
Merged

Dragorn421 merged 3 commits into
zeldaret:mainfrom
Dragorn421:rm_inc_src

Conversation

@Dragorn421

Copy link
Copy Markdown
Collaborator

No description provided.

@Dragorn421

Copy link
Copy Markdown
Collaborator Author

Also just now noticed the includes style doesn't define the order for src/ includes. Where should those go?

@mzxrules

mzxrules commented Sep 2, 2026 •

Copy link
Copy Markdown
Contributor

As I've said before in MM decomp, I would just go alphabetically (e.g. assets/, src/). I see no reason to make the rules more complex

@Dragorn421 Dragorn421 changed the title Remove src/ from include path Remove src/ from include path and consider src/ includes in includes style Sep 2, 2026
@Dragorn421 Dragorn421 added the One approval Has one approval, can be merged in 48 hours if nothing else comes up label Sep 14, 2026
@Dragorn421
Dragorn421 merged commit 5d80451 into zeldaret:main Sep 17, 2026
19 checks passed
@Dragorn421
Dragorn421 deleted the rm_inc_src branch September 17, 2026 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

One approval Has one approval, can be merged in 48 hours if nothing else comes up

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants