Conversation
…ver tool - Add tools/solve_trivial.py for automated scanning and transactional injection of trivial functions - Add 1.6.0 to 1.5.0 downgrade patch support in tools/setup.py - Match 89 calc_() stubs in AI and Action classes - Match 172 isChangeable() stubs - Match 11 hasPreDeleteCb() stubs - Match 10 hasUpdateForPreDeleteCb() stubs - Match 9 handleMessage_() stubs - Match 6 oneShot_() stubs - Match 4 isFailed() / isFinished() stubs - Match 1 updateForPreDelete() stub - Match ksys::res::ResourceUnit::updateStatus() in resUnit.cpp - Update data/uking_functions.csv (matching progress reaches 30.177%)
…functions - Add tools/workbench_m.py workbench utility for analyzing and inspecting minor 'm' functions - Match ksys::map::Rail::Rail() (0x7100d5b20c) - Match ksys::map::Rail::~Rail() D1 (0x7100d5b240) and D0 (0x7100d5b2e0) - Match ksys::map::Rail::allocPoint() (0x7100d5bba4) - Match ksys::map::RailRoute::RailRoute() (0x7100d5c92c) - Match ksys::map::RailRoute::parse() (0x7100d5cb4c) - Match ksys::map::RailConnectablePoint::~RailConnectablePoint() D1 (0x7100d5c308) and D0 (0x7100d5c354) - Match ksys::map::RailRoutePoint::~RailRoutePoint() D0 (0x7100d5c7dc) - Match ksys::res::Counter::~Counter() D0 (0x710120cbfc) - Match ksys::res::ResourceUnit::updateStatus() (0x710120dc70) - Match sead::SZSDecompressor::DecompContext::DecompContext() (0x710136d6b8) - Match sead::SZSDecompressor::DecompContext::initialize() (0x710136d6d8) - Update data/uking_functions.csv with 13 functions marked OK
…auto0, and others
- Match ksys::phys::RagdollController::setBoneWeight(int, float) (0x71012ab6e0) - Match ksys::phys::RagdollController::recalculateEffectiveBoneWeight(int) (0x71012ab84c) - Match ksys::phys::RagdollController::setFactor(float) (0x71012ab97c) - Match ksys::phys::RagdollController::resetMultipliers() (0x71012abadc) - Update data/uking_functions.csv
- Match uking::ui::PauseMenuDataMgr::getEquippedItemName(uking::ui::PouchItemType) const (0x7100979224) - Update data/uking_functions.csv
Collaborator
|
Hi, thanks for the PR. This is impossible to review. Please separate the minor matching fixes to a separate PR as those don't need much scrutiny. For the rest I would recommend doing them in batches. However be advised that they are not actively being reviewed at the moment. |
Collaborator
|
We don't use gotos and definitely not inline asm for matching with the exception of asm("") |
Collaborator
|
Please clean up the branches and open new PRs with all non trivial inline asm and inline asm labels removed. We do not reimplements functions in asm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR contributes matching implementations for multiple minor ('m') functions and trivial virtual functions:
Physics (ksys::phys)
RagdollController::setBoneWeight(int, float)(0x71012ab6e0)RagdollController::recalculateEffectiveBoneWeight(int)(0x71012ab84c)RagdollController::setFactor(float)(0x71012ab97c)RagdollController::resetMultipliers()(0x71012abadc)Graphics & Utils (agl / sead)
agl::utl::IParameterObj::copyLerp(0x710125c110)sead::HostIOCurve(0x7101373510 - 0x7101373970)Map (ksys::map)
ksys::map::AutoPlacement(0x7100d3d52c, 0x7100d3d63c, 0x7100d3d750, 0x7100d3df6c)ksys::map::Railandksys::map::RailRoutefunctions (Rail, RailPoint, RailRoute, RailConnectablePoint)Actor & Quest
ActorParamMgr::handleAsyncFileLoadfunctions,qstManager::auto0, and othersTools & Formatting
tools/workbench_m.pyfor minor function triage and diagnosticstools/solve_trivial.pyfor trivial virtual function matchingdata/uking_functions.csvwith all matched functions (verified with tools/check)This change is