Repository navigation
✨ use the Linkit user picker to add group members - #164
Merged
Merged
Conversation
Replace the free-text username field in the group manage panel with the controlled multiple LinkitUserPicker; the selected user IDs post straight to the membership endpoint. Drop the unused conversation.memberPlaceholder locale key and bump to 0.1.101.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The group manage panel adds members through the controlled
LinkitUserPickerinstead of a free-text username field:LinkitUserPickerwithmultiple+value: string[]/onValueChange; each selected user ID posts straight toPOST /api/conversations/{id}/members, dropping the username→profile lookup step.group.membersPlaceholder("Search username, UUID or note" / "搜索用户名、UUID 或备注"); the unusedconversation.memberPlaceholderkey is removed from en/zh.Release
Complexity
Verification
web:npm ci && npm run check— 51 tests pass, including the rewritten source-contract tests ("member adding uses the controlled multi user picker", "only the owner removes members"); typecheck, eslint, build, portal-layering all pass.packages/linkit-react-components:npm ci && npm run typecheck && npm test && npm run build && npm run pack:check— 56 tests pass.cargo fmt --check+cargo clippy --all-targets --all-features --locked -- -D warnings— clean (no Rust source changes in this PR).