spec: Draft FMA extension field accelerator#809
Conversation
Kimi Code ReviewAutomated review by Kimi (Moonshot AI) |
Codex Code Review
|
erik-3milabs
left a comment
There was a problem hiding this comment.
Am I correct in understanding that this PR is not yet complete? Right now, there does not seem to be a way to get the information out of the "Extension Field Realm" back to RAM/MEMORY land and interact with it. (I seem to recall we considered having assertions in the Fext-Realm, instead of the load-back, but I don't see any signs this PR introduces that solution yet)
|
Indeed, the intention was to have an |
15d0985 to
e0a13e2
Compare
59b5636 to
fe92c27
Compare
| This chip asserts that a field extension element in the ABB is zero. | ||
| It uses #nr_variables variables spanning #nr_columns columns and #nr_interactions interactions. |
There was a problem hiding this comment.
You forgot to recompute #nr_variables, #nr_columns, and #nr_interactions.
There was a problem hiding this comment.
Also, please highlight that the addr is read from A0.
erik-3milabs
left a comment
There was a problem hiding this comment.
Please rebase against spec/reg and update the six register accesses introduced in the fext_*.toml files.
Co-authored-by: Erik <159244975+erik-3milabs@users.noreply.github.com>
Co-authored-by: Erik <159244975+erik-3milabs@users.noreply.github.com>
No description provided.