Delete sensitive values after use#154
Open
xoloki wants to merge 2 commits into
Open
Conversation
xoloki
marked this pull request as ready for review
April 14, 2025 05:59
xoloki
marked this pull request as draft
April 14, 2025 18:55
xoloki
marked this pull request as ready for review
April 14, 2025 19:12
jferrant
previously approved these changes
Apr 15, 2025
xoloki
force-pushed
the
missing-deletions
branch
from
April 16, 2025 15:50
827f1d8 to
2bbadb5
Compare
jferrant
previously approved these changes
Apr 16, 2025
xoloki
force-pushed
the
missing-deletions
branch
from
April 28, 2025 23:32
2bbadb5 to
90f9958
Compare
djordon
reviewed
Apr 29, 2025
djordon
left a comment
djordon
left a comment
Collaborator
There was a problem hiding this comment.
I barely started, more to come.
xoloki
force-pushed
the
missing-deletions
branch
from
April 30, 2025 14:02
90f9958 to
3a58aee
Compare
xoloki
force-pushed
the
missing-deletions
branch
2 times, most recently
from
May 6, 2025 21:14
847b39a to
b56ae07
Compare
xoloki
force-pushed
the
missing-deletions
branch
3 times, most recently
from
May 15, 2025 15:12
eb515e2 to
a0fbbf4
Compare
delete sensitive values in the signer after dkg and signing clear sensitive data from coordinators add helper functions to zero out schnorr::ID and PolyCommitment; zero out dkg_public_shares and keep after reset in dkg_ended add helper functions to check if a schnorr::ID and PolyCommitment has been zeroed out; add test to see if sensitive data has been cleared add missing tests to frost coordinator fix comment on PolyCommitment::is_zero use values fn to iterate over map values use descriptive field names in schnorr::ID fix rebase fmt fixes
djordon
reviewed
May 15, 2025
Comment on lines
+77
to
+81
| /// Zero out the schnorr proof | ||
| pub fn zero(&mut self) { | ||
| self.random_commitment = Point::new(); | ||
| self.sigma_response = Scalar::zero(); | ||
| } |
Collaborator
There was a problem hiding this comment.
This function should probably be named zeroize, since zero suggests that it will return zero.
Collaborator
There was a problem hiding this comment.
Same thing for PolyCommitment::zero.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR deletes sensitive values after use to prevent protocol attacks, as per the
FROSTpaper.Fixes #68 ; fixes #77