Skip to content

refactor(perf-test): use WaitGroup.Go for seed workers - #2056

Open
daixiheguu wants to merge 1 commit into
xmtp:mainfrom
daixiheguu:my_feature
Open

daixiheguu wants to merge 1 commit into
xmtp:mainfrom
daixiheguu:my_feature

Conversation

@daixiheguu

@daixiheguu daixiheguu commented Aug 25, 2026 •

Copy link
Copy Markdown

Use sync.WaitGroup.Go (Go 1.25) to replace the manual Add/Done pattern, reducing boilerplate and eliminating mismatched counter bugs.

More info: golang/go#63796

Note

Replace manual WaitGroup.Add/Done with WaitGroup.Go in runDAUBlast seed workers

Refactors the seeding worker loop in dau.go to use seedWg.Go instead of the manual go + Add/Done pattern. The worker function now references the outer loop variable w directly instead of taking a wIdx parameter.

Macroscope summarized 491a19a.

@daixiheguu
daixiheguu requested a review from a team as a code owner August 25, 2026 10:10
@octane-security-app

Copy link
Copy Markdown

Summary by Octane

New Files

No new files were added.

Updated Files

  • dau.go: Modified to use seedWg.Go instead of seedWg.Add and spawn goroutine; logic simplified by removing indexes and enhancing topic range assignments.

🔗 Commit Hash: 491a19a

@octane-security-app

Copy link
Copy Markdown

Overview

Octane AI analysis has finished. No vulnerabilities were found. Cheers! 🎉🎉🎉


🔗 Commit Hash: 491a19a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant