fix(utils): add negative int validation in Int32ToUint32, Int64ToUint64, and Int32SliceToUint32Slice - #2048
Open
yappermoar-boop wants to merge 1 commit into
Conversation
…64, and Int32SliceToUint32Slice
Summary by OctaneNew ContractsNo new contracts were added. Updated Contracts
🔗 Commit Hash: 73df0ee |
Overview
Detailed findings
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added ErrNegativeInt validation in pkg/utils/number.go and pkg/utils/slice.go. Added Int32ToUint32 and Int64ToUint64 conversion helpers that return ErrNegativeInt if given negative inputs. Updated Int32SliceToUint32Slice to return ([]uint32, error) and reject negative int32 values rather than wrapping them into unexpected large uint32 integers.
Note
Add negative int validation to
Int32ToUint32,Int64ToUint64, andInt32SliceToUint32SliceInt32ToUint32andInt64ToUint64in number.go that return a newErrNegativeInterror instead of silently casting negative values.Int32SliceToUint32Slicein slice.go to return([]uint32, error), returningErrNegativeInton the first negative element found.Int32SliceToUint32Slicenow has a two-value return; all existing callers must be updated to handle the new error return.Macroscope summarized 73df0ee.