Reject invalid byte counts in sync APIs - #105
Open
soul-sol wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reject negative byte counts before they can corrupt
ogg_sync_stateaccounting.ogg_sync_wrote(oy, -1)currently decrementsoy->filland reports success. The nextogg_sync_buffer()then returns a pointer one byte before the allocation, so an ordinary caller write becomes a heap-buffer-overflow. The existing addition-based capacity check can also overflow for a sufficiently large positive count.This change uses a subtraction-based capacity check, rejects negative writes without mutating state, and makes
ogg_sync_buffer()reject negative requested sizes. The framing self-test verifies the error returns and unchanged fill position.Validation:
make checkwith GCC,-Wall -Wextra -Werrormake checkwith Clang ASan+UBSan