Repository navigation
fix(syncfiles): retain the client name when node lookup fails - #7971
Merged
dhilst merged 5 commits intoOct 23, 2026
Merged
Conversation
Keep the original client name for the rejection diagnostic. Use the resolved node only for dispatch, without changing identity or copy-command handling.
Check the original hostname in the unresolved-node diagnostic. Keep blank and missing-client rejection covered without sending a copy request.
Drive the real xdsh and DSHCLI parser from syncfiles and updatenode. Capture only the external copy boundary and preserve inherited identity behavior.
Exercise certificate policy and real SSH copies in a disposable MN/SN/node fixture. This test is opt-in and skips in ordinary CI without XCAT_SYNCFILES_LIVE_CONFIG.
Document the restricted certificate policy, required tools and cleanup limits. Distinguish the fixture from the default certificate-free postscript path.
dhilst
approved these changes
Oct 23, 2026
dhilst
added a commit
to VersatusHPC/xcat-core
that referenced
this pull request
Oct 23, 2026
Clean against the master that now carries xcat-core/xcat2#7968, xcat2#7970, xcat2#7971, xcat2#7975, xcat2#7978 and xcat2#7980. xcat2#7968 touches buildrpms.pl and release_repository.t as this branch does, in disjoint regions -- the locking sites here, createrepo_dir, index_repo and sign_repo_dir there -- which a review of xcat2#7968 measured before it landed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keep the original client hostname in the diagnostic when syncfiles cannot resolve it to a node. Continue rejecting the request without starting a copy.
Add coverage for xdcp and updatenode identity precedence and authenticated MN/SN file delivery. Keep certificate authorization, inherited user settings and copy behavior unchanged.