Repository navigation
Fix crashes when a Python grid cell editor overrides TryActivate - #3009
Merged
Merged
Conversation
The virtual handler for TryActivate couldn't copy the Python result into its return value, because wxGridActivationResult has const members and so no assignment operator. sip then called a NULL assign helper, which asserts in debug builds and is an access violation in release builds. The handler's %InstanceCode also kept a pointer to a stack local, so its default result pointed at a destroyed object. Give TryActivate a virtual catcher that copy-constructs the result and returns it directly, reporting an error and returning DoNothing() when the Python method fails or returns the wrong type, and make the default result static. Fixes wxWidgets#2899
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The virtual handler for TryActivate couldn't copy the Python result into its return value, because wxGridActivationResult has const members and so no assignment operator. sip then called a NULL assign helper, which asserts in debug builds and is an access violation in release builds. The handler's %InstanceCode also kept a pointer to a stack local, so its default result pointed at a destroyed object.
Give TryActivate a virtual catcher that copy-constructs the result and returns it directly, reporting an error and returning DoNothing() when the Python method fails or returns the wrong type, and make the default result static.
Fixes #2899