chore(agent-runner): adopt eslint-config-agent (recommended-incremental) - #102
Open
tupe12334 wants to merge 1 commit into
Open
chore(agent-runner): adopt eslint-config-agent (recommended-incremental)#102tupe12334 wants to merge 1 commit into
tupe12334 wants to merge 1 commit into
Conversation
agent-runner is the only JavaScript in this repo and had no ESLint setup at all, so src/index.js was never linted. Wire in the shared eslint-config-agent config. Starts on the recommended-incremental preset (divisive strict rules disabled, everything else at warn level): it reports 45 warnings and 0 errors here, so `pnpm lint` exits 0 while the backlog stays visible. Promote to `recommended` or the strict default once burned down. Also ignores node_modules/, which the Rust-oriented .gitignore did not cover, and pins pnpm's allowBuilds decisions so `pnpm install` does not exit non-zero on ERR_PNPM_IGNORED_BUILDS. No behaviour change: src/index.js is untouched. Closes #101 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #101
What
agent-runner/is the only JavaScript in this repo and had no ESLint setup at all —agent-runner/src/index.jswas never linted. This wires in the sharedeslint-config-agentconfig.There was no prior config to migrate; this is a from-zero adoption.
Changes
agent-runner/package.jsoneslint,eslint-config-agent,globalsdevDeps + alintscriptagent-runner/eslint.config.jseslint-config-agent/recommended-incrementalagent-runner/pnpm-lock.yamlagent-runner/pnpm-workspace.yamlallowBuildsdecisions (see below).gitignorenode_modules/(the existing file is Rust-oriented)src/index.jsis not modified — no behaviour change, no Rust code touched, no CI workflow touched.Preset choice
Starting on
eslint-config-agent/recommended-incremental(divisive strict rules disabled, everything else downgraded to warning). On this file that is 45 warnings, 0 errors, sopnpm lintexits 0 rather than landing a large behaviour-changing diff up front. The backlog is mostlyno-consoleon the server's startup/lifecycle logging,unicorn/prevent-abbreviationsonreq/res/err,no-restricted-syntaxon directprocess.envaccess, and JSDoc formatting — all worth burning down separately, after which the preset can be promoted torecommendedor the strict default.Two small config accommodations, both commented inline:
process/Buffer/consoleundefined underno-undefin this server.react.versionpinned. The shared config leaves eslint-plugin-react on"detect"; with no React installed here, detection fails and prints a warning on every run. No React rules actually apply.pnpm-workspace.yamlis needed because pnpm 11 failspnpm installwithERR_PNPM_IGNORED_BUILDSunless the transitively-pulled build scripts get an explicit decision. All three are declined — none is needed for linting.Verification
Run locally from
agent-runner/against a cleannode_modules:pnpm install→ exit 0pnpm lint→ exit 0 (45 warnings, 0 errors)node src/index.jsstill boots andPOST /delegatestill returns{"accepted":true,...}Opened by the "Scout & wire eslint-config-agent adoption → Slack" moadim routine.