ML-KEM/ML-DSA: unaligned reads#10707
Open
SparkiDev wants to merge 1 commit into
Open
Conversation
|
SparkiDev
force-pushed
the
mlkem_mldsa_unaligned
branch
from
12c030e to
1900da0
Compare
Use readUnaligned32/64 to ensure no unaligned read faults. Updated implementations of read/write unaligned 32/64 to not worry about alignment on CPUs that are known to not care.
SparkiDev
force-pushed
the
mlkem_mldsa_unaligned
branch
from
1900da0 to
bce9fdd
Compare
Contributor
Author
|
Jenkins: retest this please FIPS aborted |
SparkiDev
requested review from
wolfSSL-Fenrir-bot
and removed request for
wolfSSL-Fenrir-bot
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #10707
Scan targets checked: wolfcrypt-bugs, wolfcrypt-rs-bugs, wolfcrypt-src, wolfssl-bugs, wolfssl-src
No new issues found in the changed files. ✅
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Use readUnaligned32/64 to ensure no unaligned read faults.
Updated implementations of read/write unaligned 32/64 to not worry about alignment on CPUs that are known to not care.
Fixes F1399
Testing
Intel build of ML-KEM and ML-DSa.