Add support for LMS and XMSS#352
Conversation
padelsbach
force-pushed
the
lms-xmss
branch
2 times, most recently
from
e01c4e8 to
322c2ba
Compare
padelsbach
force-pushed
the
lms-xmss
branch
2 times, most recently
from
d524cee to
c9dad02
Compare
|
wolfSSL/wolfssl#10488 is required for CI to pass |
padelsbach
force-pushed
the
lms-xmss
branch
2 times, most recently
from
d104594 to
2c5db59
Compare
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #352
Scan targets checked: wolfhsm-core-bugs, wolfhsm-crypto-bugs, wolfhsm-src
Findings: 3
3 finding(s) posted as inline comments (see file-level comments below)
This review was generated automatically by Fenrir. Findings are non-blocking.
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #352
Scan targets checked: wolfhsm-core-bugs, wolfhsm-crypto-bugs, wolfhsm-src
Findings: 2
2 finding(s) posted as inline comments (see file-level comments below)
This review was generated automatically by Fenrir. Findings are non-blocking.
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #352
Scan targets checked: wolfhsm-core-bugs, wolfhsm-crypto-bugs, wolfhsm-src
Findings: 2
2 finding(s) posted as inline comments (see file-level comments below)
This review was generated automatically by Fenrir. Findings are non-blocking.
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #352
Scan targets checked: wolfhsm-core-bugs, wolfhsm-crypto-bugs, wolfhsm-src
No new issues found in the changed files. ✅
…LMS and WH_KEY_ALGO_XMSS
|
Bunch of updates pushed to address the big items 1-5 in your general comment above. @Frauschi, would you mind reviewing again to see if we are aligned? I'll continue to clean up the smaller items in the various comments. |
|
@padelsbach I reviewed your changes and resolved the comments that are already handled. I think most of the bigger issues are already handled, with only the big key gen state handling and the structure for the in memory layout still open. |
…r reserved field being 0
|
@Frauschi, another big update. Please re-review if you have a chance |
Frauschi
left a comment
Frauschi
left a comment
There was a problem hiding this comment.
Mostly LGTM now, thanks for fixing all the issues!
Two things are still open:
- The key gen handling with the write-callback, see my new comment in the thread.
- Some places in the code need more gating for
VERIFY_ONLY, mostly in wh_crypto.c.
|
@Frauschi, another update addressing those last two items. |
5 participants
Requires wolfSSL/wolfssl#10380 to be merged first (done).
Adds support for "stateful" PQC using crypto callbacks added to wolfssl.