Repository navigation
push helm charts to quay.io - #22051
Conversation
…, add tag and digest to build.json
…g/push-to-quay branch
| echo "CHART_REPO=$CHART_REPO" >> $GITHUB_ENV | ||
|
|
||
| - name: Set up ORAS | ||
| uses: oras-project/setup-oras@v1 |
There was a problem hiding this comment.
GitHub Actions step uses a mutable tag or branch reference. Tags and branch names can be silently repointed by the action owner, enabling supply-chain attacks — as seen in the trivy-action and kics-github-action compromises. Pin the reference to a full 40-character commit SHA instead, e.g. uses: actions/checkout@8ade135a41bc03ea155e62e844d188df1ea18608.
🧼 Fixed in commit 7a3344c 🧼
| test: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v4 |
There was a problem hiding this comment.
GitHub Actions step uses a mutable tag or branch reference. Tags and branch names can be silently repointed by the action owner, enabling supply-chain attacks — as seen in the trivy-action and kics-github-action compromises. Pin the reference to a full 40-character commit SHA instead, e.g. uses: actions/checkout@8ade135a41bc03ea155e62e844d188df1ea18608.
🚀 Fixed in commit 7a3344c 🚀
| version: '3.12.2' | ||
|
|
||
| - name: Set up ORAS | ||
| uses: oras-project/setup-oras@v1 |
There was a problem hiding this comment.
GitHub Actions step uses a mutable tag or branch reference. Tags and branch names can be silently repointed by the action owner, enabling supply-chain attacks — as seen in the trivy-action and kics-github-action compromises. Pin the reference to a full 40-character commit SHA instead, e.g. uses: actions/checkout@8ade135a41bc03ea155e62e844d188df1ea18608.
🧹 Fixed in commit 7a3344c 🧹
|
Semgrep found 1 Using variable interpolation |
This reverts commit 7a3344c.
| on: | ||
| push: | ||
| branches: [master, dev, release/*, new-navigation] | ||
| branches: [master, dev, release/*, new-navigation, smatting/push-to-quay] |
There was a problem hiding this comment.
I think this can be removed?
| @@ -0,0 +1,79 @@ | |||
| name: Stefan Test | |||
There was a problem hiding this comment.
Should we rename the filename and the name of the workflow?
|
|
||
| jobs: | ||
| test: | ||
| runs-on: ubuntu-latest |
There was a problem hiding this comment.
| runs-on: ubuntu-latest | |
| runs-on: ubuntu-24.04 |
Update build.json tag field to reference the helm chart version instead of the Docker image tag, ensuring consistency with what's pushed to OCI. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
Add a step to trigger the webapp-release-stream-updated dispatch event to wireapp/wire-gov-bundles after pushing the build artifact to Quay, using GitHub App authentication. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
|
|
||
| - name: Generate GitHub App token | ||
| id: app-token | ||
| uses: actions/create-github-app-token@v1 |
There was a problem hiding this comment.
Semgrep identified an issue in your code:
GitHub Actions step uses mutable tag @v1 instead of a pinned commit SHA, allowing attackers who control the action to inject malicious code that exfiltrates your GitHub App credentials.
More details about this
The GitHub Actions step references actions/create-github-app-token@v1, which uses a mutable version tag instead of a pinned commit SHA. An attacker with control of the actions/create-github-app-token repository could update the v1 tag to point to a malicious version at any time. Here's how this could be exploited:
- Attacker gains access to the actions/create-github-app-token repository (either through compromised maintainer credentials or by forking it)
- Attacker updates the
v1tag to point to a new commit containing malicious code - Next time this workflow runs, GitHub Actions downloads and executes the malicious version instead of the legitimate one
- The malicious code runs with access to
${{ secrets.WIRE_ONPREM_AUTOMATION_APP_ID }}and${{ secrets.WIRE_ONPREM_AUTOMATION_PRIVATE_KEY }}— your GitHub App credentials - Attacker uses the stolen credentials to create tokens and manipulate repositories under
wireapporganization, or trigger unauthorized dispatches towireapp/wire-gov-bundles
This is a supply-chain attack: your workflow trusts an external action that can be silently modified. The v1 tag is mutable and controlled by whoever maintains that action.
To resolve this comment:
✨ Commit fix suggestion
| uses: actions/create-github-app-token@v1 | |
| uses: actions/create-github-app-token@4c8f2d7c5b9d6a1e3f0b2c4d6e8f1a3b5c7d9e0f |
View step-by-step instructions
-
Replace the mutable GitHub Action tag in the
usesline with a full 40-character commit SHA.
Changeuses: actions/create-github-app-token@v1touses: actions/create-github-app-token@<full-40-char-commit-sha>. -
Get the SHA from the
actions/create-github-app-tokenrepository release or commit that matches the version you intend to use.
For example, keep the same action but pin it to a specific revision instead of a moving tag likev1. -
Keep the rest of the step unchanged, including
with:inputs such asapp-id,private-key, andowner.
Pinning to a commit SHA prevents the action owner from silently changing what code runs under the same tag.
💬 Ignore this finding
Reply with Semgrep commands to ignore this finding.
/fp <comment>for false positive/ar <comment>for acceptable risk/other <comment>for all other reasons
Alternatively, triage in Semgrep AppSec Platform to ignore the finding created by github-actions-mutable-action-tag.
You can view more details about this finding in the Semgrep AppSec Platform.
No description provided.