Repository navigation
feat: add passkey functionality [WPB-27034] - #9756
Merged
Merged
Conversation
e-maad
requested review from
arjita-mitra,
otto-the-bot,
screendriver,
thisisamir98 and
zskhan
as code owners
September 29, 2026 14:11
e-maad
force-pushed
the
feat/add-passkeys-functionality-WPB-27034
branch
from
September 29, 2026 15:02
d003e29 to
e9a6376
Compare
e-maad
force-pushed
the
feat/add-passkeys-functionality-WPB-27034
branch
from
September 30, 2026 08:30
e9a6376 to
78a34de
Compare
|
Semgrep found 1 🟡 Medium severity issue identified in your code: Detected possible user input going into a View Dataflow Graphflowchart LR
classDef invis fill:white, stroke: none
classDef default fill:#e7f5ff, color:#1c7fd6, stroke: none
subgraph File0["<b>bin/build-tools/lib/build-macos.ts</b>"]
direction LR
%% Source
subgraph Source
direction LR
v0["<a href=https://github.com/wireapp/wire-desktop/blob/bcd7ca5fa856bc9b27852d4d4f9db4212ee59167/bin/build-tools/lib/build-macos.ts#L164 target=_blank style='text-decoration:none; color:#1c7fd6'>[Line: 164] packagerConfig</a>"]
end
%% Intermediate
subgraph Traces0[Traces]
direction TB
v2["<a href=https://github.com/wireapp/wire-desktop/blob/bcd7ca5fa856bc9b27852d4d4f9db4212ee59167/bin/build-tools/lib/build-macos.ts#L164 target=_blank style='text-decoration:none; color:#1c7fd6'>[Line: 164] packagerConfig</a>"]
v3["<a href=https://github.com/wireapp/wire-desktop/blob/bcd7ca5fa856bc9b27852d4d4f9db4212ee59167/bin/build-tools/lib/build-macos.ts#L189 target=_blank style='text-decoration:none; color:#1c7fd6'>[Line: 189] await</a>"]
v4["<a href=https://github.com/wireapp/wire-desktop/blob/bcd7ca5fa856bc9b27852d4d4f9db4212ee59167/bin/build-tools/lib/build-macos.ts#L189 target=_blank style='text-decoration:none; color:#1c7fd6'>[Line: 189] ]</a>"]
v5["<a href=https://github.com/wireapp/wire-desktop/blob/bcd7ca5fa856bc9b27852d4d4f9db4212ee59167/bin/build-tools/lib/build-macos.ts#L189 target=_blank style='text-decoration:none; color:#1c7fd6'>[Line: 189] buildDir</a>"]
v6["<a href=https://github.com/wireapp/wire-desktop/blob/bcd7ca5fa856bc9b27852d4d4f9db4212ee59167/bin/build-tools/lib/build-macos.ts#L193 target=_blank style='text-decoration:none; color:#1c7fd6'>[Line: 193] appFile</a>"]
v7["<a href=https://github.com/wireapp/wire-desktop/blob/bcd7ca5fa856bc9b27852d4d4f9db4212ee59167/bin/build-tools/lib/build-macos.ts#L201 target=_blank style='text-decoration:none; color:#1c7fd6'>[Line: 201] manualMacOSSign</a>"]
v8["<a href=https://github.com/wireapp/wire-desktop/blob/bcd7ca5fa856bc9b27852d4d4f9db4212ee59167/bin/build-tools/lib/build-macos.ts#L250 target=_blank style='text-decoration:none; color:#1c7fd6'>[Line: 250] appFile</a>"]
v9["<a href=https://github.com/wireapp/wire-desktop/blob/bcd7ca5fa856bc9b27852d4d4f9db4212ee59167/bin/build-tools/lib/build-macos.ts#L272 target=_blank style='text-decoration:none; color:#1c7fd6'>[Line: 272] await</a>"]
v10["<a href=https://github.com/wireapp/wire-desktop/blob/bcd7ca5fa856bc9b27852d4d4f9db4212ee59167/bin/build-tools/lib/build-macos.ts#L272 target=_blank style='text-decoration:none; color:#1c7fd6'>[Line: 272] addons</a>"]
v11["<a href=https://github.com/wireapp/wire-desktop/blob/bcd7ca5fa856bc9b27852d4d4f9db4212ee59167/bin/build-tools/lib/build-macos.ts#L276 target=_blank style='text-decoration:none; color:#1c7fd6'>[Line: 276] of</a>"]
v12["<a href=https://github.com/wireapp/wire-desktop/blob/bcd7ca5fa856bc9b27852d4d4f9db4212ee59167/bin/build-tools/lib/build-macos.ts#L276 target=_blank style='text-decoration:none; color:#1c7fd6'>[Line: 276] addon</a>"]
end
v2 --> v3
v3 --> v4
v4 --> v5
v5 --> v6
v6 --> v7
v7 --> v8
v8 --> v9
v9 --> v10
v10 --> v11
v11 --> v12
%% Sink
subgraph Sink
direction LR
v1["<a href=https://github.com/wireapp/wire-desktop/blob/bcd7ca5fa856bc9b27852d4d4f9db4212ee59167/bin/build-tools/lib/build-macos.ts#L281 target=_blank style='text-decoration:none; color:#1c7fd6'>[Line: 281] addon</a>"]
end
end
%% Class Assignment
Source:::invis
Sink:::invis
Traces0:::invis
File0:::invis
%% Connections
Source --> Traces0
Traces0 --> Sink
|
e-maad
enabled auto-merge
October 7, 2026 12:06
thisisamir98
reviewed
Oct 7, 2026
thisisamir98
reviewed
Oct 7, 2026
thisisamir98
reviewed
Oct 7, 2026
thisisamir98
reviewed
Oct 7, 2026
thisisamir98
reviewed
Oct 7, 2026
thisisamir98
reviewed
Oct 7, 2026
thisisamir98
reviewed
Oct 7, 2026
thisisamir98
reviewed
Oct 7, 2026
thisisamir98
reviewed
Oct 7, 2026
thisisamir98
approved these changes
Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Test apps: