Skip to content

Manually add ffmpeg and ffprobe - #805

Draft
whyboris wants to merge 6 commits into
mainfrom
ffmpeg-manual
Draft

whyboris wants to merge 6 commits into
mainfrom
ffmpeg-manual

Conversation

@whyboris

@whyboris whyboris commented Mar 15, 2023 •

Copy link
Copy Markdown
Owner

😓 worse in some ways, but allows for manually choosing which version of FFmpeg to include 🤔

Currently Mac builds are broken with this -- because Mac complains about the security of executing a file that's already part of the build package :trollface:

And build sizes are double of what they were before 😓 -- so probably not worth merging this in (unless I figure out how to bundle things better) 😓

@whyboris
whyboris marked this pull request as draft March 15, 2023 23:09
@whyboris

whyboris commented Jun 13, 2026 •

Copy link
Copy Markdown
Owner Author

This may solve #933 🚀

If available, I can include FFmpeg that has hardware acceleration - creating a separate release just for nvidia cards 🤔

@whyboris

Copy link
Copy Markdown
Owner Author

Ran a bunch of tests, looks like -hwaccel cuda doesn't speed up, but instead slows down the extraction process 🤦‍♂️

So for now, I intend to use regular FFmpeg without cuda support 👌

This PR can still merge - as it may be nice to allow manual selection of FFmpeg without having to rely on an auto-downloader 🤔

@whyboris

whyboris commented Jun 18, 2026 •

Copy link
Copy Markdown
Owner Author

If I find time I will try to build FFmpeg from source with the --disable-encoders flag -- since VHA only needs to decode (will need to check if this stripped down FFmpeg can still write a jpg).

If it works out, I can have VHA's build be much smaller 🚀

Currently eager to release 3.3.0 so this will have to wait for another release 🙆‍♂️

@whyboris

whyboris commented Sep 1, 2026 •

Copy link
Copy Markdown
Owner Author

Couldn't build version 3.3.0 on a Mac for a while :trollface:

Turned out I could use process.resourcesPath string that gets added via Electron

Using this branch: mac-ffmpeg 🚀 see the PR #990

@whyboris whyboris mentioned this pull request Sep 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant