Repository navigation
fix: give every confirmation prompt its own skip setting - #7
Merged
Merged
Conversation
The run confirmation appeared whenever more than one task was selected and never consulted the settings, so there was no way to turn it off. A single task had no confirmation at all, which made the prompt depend on how many tasks happened to be selected rather than on what was about to run. Route every run through the same check, gated on a new skip_run_confirm setting, and give profile and task removal the same treatment via skip_remove_confirm. The run modal can now show a single task, so its copy handles n == 1. skip_delete_warning keeps its existing meaning: the alert shown when enabling a task's delete flag. Closes #2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2.
skip_delete_warningonly ever gated one prompt — the alert when you tick a task'sdeleteflag. The run confirmation never read the settings, so there was no way to turn it off.One opt-out per prompt, lazygit-style:
skip_delete_warningdeleteflag (unchanged)skip_run_confirmskip_remove_confirmAlso: a single task used to run with no confirmation at all. Now
randRgo down the same path, so the prompt depends on what runs rather than how many tasks are selected.fmt,clippy, 69 tests clean.