Repository navigation
test: drop environment assumptions from fixtures - #6
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two tests depended on the environment they were written in.
ui/log.rswrapping fixtures hardcoded/home/light. The path is never read — the tests only care about string length — and it shipped in the 0.1.1 crate on crates.io.paths.rs::user_placeholder_matches_the_environmentcalledenv::var("USER").unwrap(), which panics whereverUSERisn't set: build sandboxes, minimal containers, somesu/cron setups. The test also disagreed with the implementation, which falls back toLOGNAMEand then leaves{user}literal. It now checks the same sources the implementation does and asserts the literal-passthrough case.Verified with
cargo testboth normally and underenv -u USER -u LOGNAME— 69 passing either way.