test+docs: cover type aliases, document -schemaHash#8
Open
klaidliadon wants to merge 1 commit into
Open
Conversation
- add `type UserID: uint64` alias to the smoke example and regenerate the committed goldens; the alias resolves to its base type as a struct field (`uint64_t user_id`) and round-trips through the JSON codec. Alias rendering previously had no example/golden coverage. - document the -schemaHash opt-out in the README options table (v0.1.6)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two release-readiness fixes for gen-c:
type UserID: uint64and auserId: UserIDfield to_examples/smoke/example.ridl, regenerated the committed goldens. The alias resolves to its base type as a struct field (uint64_t user_id) and round-trips through the JSON codec (cJSON_CreateNumber/ decode).make diffnow guards the alias path.-schemaHashopt-out in the README options table.Regenerated with the pinned tool (webrpc-gen v0.37.2) via
make -C _examples generate; bothexample.gen.handexample.gen.care committed and passmake diffagainst the regenerated output.Note: the README "Version" cell says v0.1.6 — this flag (and the alias coverage) ships in the next tag. The
-schemaHashfeature itself is currently unreleased on master (1 commit past v0.1.5); this PR should land before / with the v0.1.6 cut.Part of the cross-generator sweep documenting
-schemaHashand closing type-alias coverage gaps.