Skip to content

Add waited-on lifecycle notifications to the agent protocol - #413

Merged
seemeroland merged 4 commits into
mainfrom
factory/orchestration-waited-on
Nov 13, 2026
Merged

seemeroland merged 4 commits into
mainfrom
factory/orchestration-waited-on

Conversation

@warp-agent-staging

@warp-agent-staging warp-agent-staging Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

Description

Add the additive WAITED_ON lifecycle type and waited_on detail. The sender identifies the waiting run, independently of parent/child direction. Regenerate checked-in Go bindings.

Justification

Support recipient-owned run_waited_on events so both native and third-party agents can learn that another run is waiting for them. Part of warpdotdev/warp-server#21004.

Sensitive Fields

  • No sensitive string fields are added.

Testing

Go generation and generated-package tests, Rust build/tests, npm ci, and TypeScript generation pass. Generation used protoc 29.3 and the repository-pinned Go plugin; Rust has no unit tests.

Related changes and landing order

Protocol: #413; server formatting: https://github.com/warpdotdev/warp-server/pull/21731 (after #21020); Claude hooks: warpdotdev/claude-code-warp#106 (after #105); Codex hooks: warpdotdev/codex-warp#11 (after #10); client: warpdotdev/warp#16809 (after both plugin releases).

Historical parent-stack UI evidence

The automated appendix below belongs to earlier web-timeline work in the parent task, not proof of this notification change. New client computer-use verification was explicitly declined.

Computer-use video recordings (8)

Opens the seeded Waiting run in the Factory MSW app, inspects history, resumes via mocked state, and follows the target link.
Factory Waiting run: open, history, resume, target link: Opens the seeded Waiting run in the Factory MSW app, inspects history, resumes via mocked state, and follows the target link.

Opens the seeded Waiting run in the Oz MSW app, expands lifecycle history, resumes via mocked state, and follows the target run link.
Oz Waiting run: history, resume, target link: Opens the seeded Waiting run in the Oz MSW app, expands lifecycle history, resumes via mocked state, and follows the target run link.

Opens the Waiting Factory trace, inspects the waiting segment tooltip and wait target, mutates the MSW fixture to resumed state, observes separated work segments, and follows the target link.
Factory waiting trace to resumed trace: Opens the Waiting Factory trace, inspects the waiting segment tooltip and wait target, mutates the MSW fixture to resumed state, observes separated work segments, and follows the target link.

Navigating Factory and Oz MSW run pages for waiting and resumed states, expanding timelines, then clicking a target link in the debugger.
Factory, Oz and debugger waiting/resumed flows: Navigating Factory and Oz MSW run pages for waiting and resumed states, expanding timelines, then clicking a target link in the debugger.

Loads Factory MSW, opens run-msw-idle-gap (waiting on two targets), inspects links and trace, then navigates to run-msw-debugging (resumed working).
Factory MSW waiting and resumed traces: Loads Factory MSW, opens run-msw-idle-gap (waiting on two targets), inspects links and trace, then navigates to run-msw-debugging (resumed working).

Reloads factory.html, navigates client-side to run-msw-debugging, hovers trace segments, and checks footer links, then run-msw-idle-gap.
Factory resumed trace tooltips and waiting footer: Reloads factory.html, navigates client-side to run-msw-debugging, hovers trace segments, and checks footer links, then run-msw-idle-gap.

Full reload of Factory MSW entry, client-side navigation to the debugging run and the idle-gap waiting run, showing footer links and trace, then the resumed trace.
Waiting and resumed run traces: Full reload of Factory MSW entry, client-side navigation to the debugging run and the idle-gap waiting run, showing footer links and trace, then the resumed trace.

Seeds MSW state for a waiting run, inspects Agents timeline and target links, then the debugger waiting-parent page and child-beta navigation.
Waiting timeline in Agents app and debugger: Seeds MSW state for a waiting run, inspects Agents timeline and target links, then the debugger waiting-parent page and child-beta navigation.

Computer-use screenshots (10)

run-msw-debugging after reload+client nav: single Coding agent Active segment, plain Follow up footer
run-msw-debugging after reload+client nav: single Coding agent Active segment, plain Follow up footer

run-msw-idle-gap: Waiting segment, Idle for 2d 9h gap, footer with child-alpha and child-beta links
run-msw-idle-gap: Waiting segment, Idle for 2d 9h gap, footer with child-alpha and child-beta links

Resumed run trace: short historical Waiting segment (1m→2m) at top and long current Active segment after idle gap
Resumed run trace: short historical Waiting segment (1m→2m) at top and long current Active segment after idle gap

Waiting run footer "Waiting for child-alpha and child-beta agents…" with child-beta target (/runs/child-beta?tab=agents&from=parent) in status bar; alpha target is /runs/child-alpha?tab=agents&from=parent
Waiting run footer "Waiting for child-alpha and child-beta agents…" with child-beta target (/runs/child-beta?tab=agents&from=parent) in status bar; alpha target is /runs/child-alpha?tab=agents&from=parent

Agents run-msw-1 collapsed timeline: "Agent waiting" with full sentence and two underlined links; Status badge Waiting
Agents run-msw-1 collapsed timeline: "Agent waiting" with full sentence and two underlined links; Status badge Waiting

Debugger waiting-parent Timeline: Agent waiting event with yellow marker and child-alpha/child-beta links
Debugger waiting-parent Timeline: Agent waiting event with yellow marker and child-alpha/child-beta links

Debugger child-beta timeline: INPROGRESS run with retained Agent working → Agent waiting → Agent working history
Debugger child-beta timeline: INPROGRESS run with retained Agent working → Agent waiting → Agent working history

Collapsed Agent waiting row with orange circular pause marker and "waiting for messages from child-alpha, child-beta" sentence
Collapsed Agent waiting row with orange circular pause marker and "waiting for messages from child-alpha, child-beta" sentence

Collapsed Agent blocked row: orange rounded-square-in-circle marker, "The run needs attention before it can continue."
Collapsed Agent blocked row: orange rounded-square-in-circle marker, "The run needs attention before it can continue."

Final state: collapsed Agent waiting row with orange pause marker and child-alpha/child-beta links
Final state: collapsed Agent waiting row with orange pause marker and child-alpha/child-beta links

@warp-agent-staging

Copy link
Copy Markdown
Contributor Author

This PR was generated with Warp.

Comment @warp-staging-factory on this PR to send it follow-up work.

View run View conversation View on Slack

@warp-agent-staging

Copy link
Copy Markdown
Contributor Author

This PR was generated with Warp, requested by @seemeroland.

Comment @warp-staging-factory on this PR to send it follow-up work.

View run View conversation View on Slack

@warp-agent-staging
warp-agent-staging Bot marked this pull request as ready for review November 12, 2026 02:04
@warp-agent-staging
warp-agent-staging Bot requested a review from a team as a code owner November 12, 2026 02:04
@warp-agent-staging
warp-agent-staging Bot requested a review from szgupta November 12, 2026 02:04

@warp-agent-staging warp-agent-staging Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overview

The additive waited-on enum/detail supports either direction without reinterpreting status events. Examined design, correctness, standards, complexity, naming, comments, test value/coverage, and security; no outstanding source findings.

Verdict

Checks: build pass, tests pass, CI green, visual proof n/a.

Found: 0 critical, 0 important, 0 suggestions, 0 nits. Approve the source change; consumer pins target the functional protocol commit, with only generated-comment layout changed afterward.

Responding as eng-factory-slim: Open session · View in factory

@seemeroland seemeroland left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's confusing what the semantics of LifecycleEvent and LifecycleEventType are. For a LifecycleEvent with any previously existing type such as LIFECYCLE_EVENT_TYPE_IN_PROGRESS, who is the sender? Is the sender the run that entered this state, and the message is sent to a different run?

Are the semantics of LIFECYCLE_EVENT_TYPE_WAITED_ON consistent? The relationship between sender_agent_id and LifecycleEventType needs to be documented and consistent

Comment thread apis/multi_agent/v1/task.proto Resolved
@seemeroland
seemeroland removed the request for review from szgupta November 12, 2026 19:59
Comment thread apis/multi_agent/v1/task.proto Resolved
@seemeroland
seemeroland merged commit 7a860ed into main Nov 13, 2026
8 checks passed
@seemeroland
seemeroland deleted the factory/orchestration-waited-on branch November 13, 2026 00:53
seemeroland pushed a commit to warpdotdev/warp that referenced this pull request Nov 17, 2026
## Description
Deliver recipient-owned `run_waited_on` notifications to native Warp
agents only. Preserve raw `run_id` as the notified run and `ref_id` as
its waiter; project the waiter explicitly into protocol
`Waiting.sender_agent_id`. Use the existing UUIDv4 lifecycle ID policy
and project Waiting to InProgress without optional status handling.

No new legacy plugin, Claude bridge, or CLI message-watch handling is
included. Third-party ACP delivery is separate in
#16876 (server wake companion
warpdotdev/warp-server#22126); this native layer
does not depend on it or a plugin release.

## Linked Issue
Tracks warpdotdev/warp-server#21004. Native server formatting:
warpdotdev/warp-server#21731 (above #21020).
Additive protocol:
warpdotdev/warp-proto-apis#413.

## Testing
- 106 focused Rust tests pass: event-stream routing, child tracking,
recipient/waiter identities and Waiting status projection.
- `cargo clippy --locked -p warp --lib --tests -- -D warnings` passes.
- Final `./script/format` and diff-check pass.
- Client computer-use verification was explicitly declined.

## Agent Mode
- [x] Warp Agent Mode

CHANGELOG-OZ: Native Warp agents receive a notification when another run
is waiting for their output.

## Historical parent-stack UI evidence
The automated appendix below belongs to earlier web-timeline work, not
proof of this native notification change. No new client visual proof is
claimed.

<!-- warp:pr-description-artifacts start -->
<!-- oz:computer-use-videos start -->
<details>
<summary>Computer-use video recordings (10)</summary>

[![Opens the seeded Waiting run in the Factory MSW app, inspects
history, resumes via mocked state, and follows the target
link.](https://staging.warp.dev/api/v1/agent/artifacts/01a18f3a-56fd-76d5-bb5a-4f81d49039b4/download)](https://platform.staging.warp.dev/artifacts/01a18f3a-54ae-7ef6-8c52-1ec3c29e5d7b)
**Factory Waiting run: open, history, resume, target link**: Opens the
seeded Waiting run in the Factory MSW app, inspects history, resumes via
mocked state, and follows the target link.

[![Opens the seeded Waiting run in the Oz MSW app, expands lifecycle
history, resumes via mocked state, and follows the target run
link.](https://staging.warp.dev/api/v1/agent/artifacts/01a18f3c-3e1d-7da4-80e6-be3ccc10ef7b/download)](https://platform.staging.warp.dev/artifacts/01a18f3c-3b2f-768d-b2b2-11f4eb8c173f)
**Oz Waiting run: history, resume, target link**: Opens the seeded
Waiting run in the Oz MSW app, expands lifecycle history, resumes via
mocked state, and follows the target run link.

[![Opens the Waiting Factory trace, inspects the waiting segment tooltip
and wait target, mutates the MSW fixture to resumed state, observes
separated work segments, and follows the target
link.](https://staging.warp.dev/api/v1/agent/artifacts/01a18f42-ce41-7ae0-9fa7-2042d5965751/download)](https://platform.staging.warp.dev/artifacts/01a18f42-cbb7-7d7c-a007-cf651e9e0681)
**Factory waiting trace to resumed trace**: Opens the Waiting Factory
trace, inspects the waiting segment tooltip and wait target, mutates the
MSW fixture to resumed state, observes separated work segments, and
follows the target link.

[![Navigating Factory and Oz MSW run pages for waiting and resumed
states, expanding timelines, then clicking a target link in the
debugger.](https://staging.warp.dev/api/v1/agent/artifacts/01a1a96a-e413-747e-871b-e05bdb889d90/download)](https://platform.staging.warp.dev/artifacts/01a1a96a-e113-705f-8b31-b2f6de652e9a)
**Factory, Oz and debugger waiting/resumed flows**: Navigating Factory
and Oz MSW run pages for waiting and resumed states, expanding
timelines, then clicking a target link in the debugger.

[![Loads Factory MSW, opens run-msw-idle-gap (waiting on two targets),
inspects links and trace, then navigates to run-msw-debugging (resumed
working).](https://staging.warp.dev/api/v1/agent/artifacts/01a1a96d-deeb-7479-bdd1-afec128812f9/download)](https://platform.staging.warp.dev/artifacts/01a1a96d-dc40-755d-8f3f-956700dfa919)
**Factory MSW waiting and resumed traces**: Loads Factory MSW, opens
run-msw-idle-gap (waiting on two targets), inspects links and trace,
then navigates to run-msw-debugging (resumed working).

[![Reloads factory.html, navigates client-side to run-msw-debugging,
hovers trace segments, and checks footer links, then
run-msw-idle-gap.](https://staging.warp.dev/api/v1/agent/artifacts/01a1a96f-b183-74c9-9267-36f99fafde35/download)](https://platform.staging.warp.dev/artifacts/01a1a96f-af19-7b5a-b641-2c4d9c222e11)
**Factory resumed trace tooltips and waiting footer**: Reloads
factory.html, navigates client-side to run-msw-debugging, hovers trace
segments, and checks footer links, then run-msw-idle-gap.

[![Full reload of Factory MSW entry, client-side navigation to the
debugging run and the idle-gap waiting run, showing footer links and
trace, then the resumed
trace.](https://staging.warp.dev/api/v1/agent/artifacts/01a1a971-bbd4-71c5-89d9-1ba896f83fb3/download)](https://platform.staging.warp.dev/artifacts/01a1a971-b9a2-779a-97fa-306ec44a9ae7)
**Waiting and resumed run traces**: Full reload of Factory MSW entry,
client-side navigation to the debugging run and the idle-gap waiting
run, showing footer links and trace, then the resumed trace.

[![Seeds MSW state for a waiting run, inspects Agents timeline and
target links, then the debugger waiting-parent page and child-beta
navigation.](https://staging.warp.dev/api/v1/agent/artifacts/01a1cd25-d3ac-71d5-94fe-4201d0b5bc6b/download)](https://platform.staging.warp.dev/artifacts/01a1cd25-cf66-76c6-9ad0-437aefff1c77)
**Waiting timeline in Agents app and debugger**: Seeds MSW state for a
waiting run, inspects Agents timeline and target links, then the
debugger waiting-parent page and child-beta navigation.

[![Shows Waiting and Blocked run rows on the real Agents and Factory
Runs lists in Chromium on
Linux.](https://staging.warp.dev/api/v1/agent/artifacts/01a1d172-5ae6-7813-88eb-ca0ec6ff3d9c/download)](https://platform.staging.warp.dev/artifacts/01a1d172-57a0-7886-b1b3-3e339cdcbf45)
**Agents and Factory Waiting/Blocked badges**: Shows Waiting and Blocked
run rows on the real Agents and Factory Runs lists in Chromium on Linux.

[![Shows the Waiting badge and expanded lifecycle timeline in Agents and
Factory, the before/after debugger templates, and a resumed run
retaining wait
history.](https://staging.warp.dev/api/v1/agent/artifacts/01a1d1a8-55c6-7d2e-9ff4-2c755d1d8f18/download)](https://platform.staging.warp.dev/artifacts/01a1d1a8-51cc-7836-a649-7f95eeb0b6ac)
**Waiting run presentation: Agents, Factory, debugger**: Shows the
Waiting badge and expanded lifecycle timeline in Agents and Factory, the
before/after debugger templates, and a resumed run retaining wait
history.

</details>
<!-- oz:computer-use-videos end -->
<!-- oz:computer-use-screenshots start -->
<details>
<summary>Computer-use screenshots (10)</summary>

![Agents Runs list with Blocked and Waiting rows, devtools
closed](https://staging.warp.dev/api/v1/agent/artifacts/01a1d170-a378-7845-bea1-eb0dafd5dc95/download)
Agents Runs list with Blocked and Waiting rows, devtools closed

![Factory Runs list with Waiting (pause glyph) and Blocked (stop square)
rows
together](https://staging.warp.dev/api/v1/agent/artifacts/01a1d172-41e8-75ec-b1be-97ebf425ab1c/download)
Factory Runs list with Waiting (pause glyph) and Blocked (stop square)
rows together

![Agents run-msw-1 seeded WAITING: Agent waiting timeline (expanded)
with child-alpha/child-beta links and orange Waiting
badge](https://staging.warp.dev/api/v1/agent/artifacts/01a1d19b-3370-79a8-89d6-89349b783454/download)
Agents run-msw-1 seeded WAITING: Agent waiting timeline (expanded) with
child-alpha/child-beta links and orange Waiting badge

![Factory run-msw-idle-gap: "Agent finished" (not waiting), trace shows
"No timeline is available for this run." and side panel stuck on
"Loading
timeline..."](https://staging.warp.dev/api/v1/agent/artifacts/01a1d19d-07b4-705f-af91-34e77fd4de60/download)
Factory run-msw-idle-gap: "Agent finished" (not waiting), trace shows
"No timeline is available for this run." and side panel stuck on
"Loading timeline..."

![Agents: Waiting for another agent badge and expanded timeline with
child-alpha/child-beta
links](https://staging.warp.dev/api/v1/agent/artifacts/01a1d1a3-abfd-7d41-ac1d-b006ec2d1531/download)
Agents: Waiting for another agent badge and expanded timeline with
child-alpha/child-beta links

![Agents resumed run: Running badge, latest "Agent working" with
historical "Waiting for another agent" row
retained](https://staging.warp.dev/api/v1/agent/artifacts/01a1d1a4-acc0-75b5-a349-a220d9643c0c/download)
Agents resumed run: Running badge, latest "Agent working" with
historical "Waiting for another agent" row retained

![Factory waiting run: footer "Waiting for another agent" with dot;
trace stages bar; timeline panel stuck on "Loading
timeline..."](https://staging.warp.dev/api/v1/agent/artifacts/01a1d1a5-af8b-7d9b-8a04-63f167a89ca9/download)
Factory waiting run: footer "Waiting for another agent" with dot; trace
stages bar; timeline panel stuck on "Loading timeline..."

![Factory resumed run: footer "Agent is working…", Timeline panel still
"Loading timeline..."
(limitation)](https://staging.warp.dev/api/v1/agent/artifacts/01a1d1a7-1df5-7a96-8b30-074afdc7b097/download)
Factory resumed run: footer "Agent is working…", Timeline panel still
"Loading timeline..." (limitation)

![Original debugger (/before): WAITING amber badge, "Agent waiting" with
orange marker and "messages from child-alpha,
child-beta"](https://staging.warp.dev/api/v1/agent/artifacts/01a1d1a7-73ec-72b7-8b16-038b9d41e873/download)
Original debugger (/before): WAITING amber badge, "Agent waiting" with
orange marker and "messages from child-alpha, child-beta"

![Revised debugger (/after): "WAITING FOR ANOTHER AGENT" purple badge,
"Waiting for another agent" purple marker with output-from-another-agent
subtext and
links](https://staging.warp.dev/api/v1/agent/artifacts/01a1d1a7-a0d5-78cd-abf7-f63233f2d48e/download)
Revised debugger (/after): "WAITING FOR ANOTHER AGENT" purple badge,
"Waiting for another agent" purple marker with output-from-another-agent
subtext and links

</details>
<!-- oz:computer-use-screenshots end -->
<!-- warp:pr-description-artifacts end -->

---------

Co-authored-by: warp-agent-staging[bot] <240773466+warp-agent-staging[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed factory:eng-factory-slim Label associated to the "eng-factory-slim" factory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants