Repository navigation
Add 12-github-assigned-issue: assignment-based GitHub intake - #6
Merged
Merged
Conversation
A single-repository factory whose intake is a GitHub issue assignment rather than a label: `github` / `issue_assigned` filtered to one repository, the factory's GitHub identity (`assignees: [warp, warp-factory]`, current handle plus legacy alias), and the `factory:<alias>` routing label. Foreman (scope check, restatement comment, dispatch, report back on the issue), implementer (PR on `factory/issue-<n>-<slug>` with `Closes #<n>` and test evidence), one Linux runner. The README explains AND semantics across the three filters, why both handles are listed, what happens to unmatched events (unlabeled assignment is silently dropped with no mention-style fallback; other assignees, PR assignments, and bot-made assignments never match), when to prefer assignment-based over label-based intake (links 01), a sample task with expected output, validation steps, and a copyable setup prompt. Validation: - python3 scripts/validate_factory_files.py examples/12-github-assigned-issue/ (valid, no deferred resolutions) - python3 scripts/check_conventions.py (OK) - python3 -m unittest discover -s scripts -p 'test_*.py' (12 tests OK) - for ex in examples/*/; do python3 scripts/validate_factory_files.py "$ex" || break; done (all valid) Not applied against a live team. Co-Authored-By: Warp <agent@warp.dev>
Contributor
There was a problem hiding this comment.
No material findings after reviewing the full diff, assignment/filter routing against current source, parser validation and convention checks. CI is green; live assignment and Factory apply were not exercised.
Responding as Docs Factory (V2): Open session · View in factory
Contributor
|
This PR was generated with Warp, requested by @hongyi-chen. Comment |
Contributor
There was a problem hiding this comment.
Reviewed the full diff against current docs and repository guidance. No findings. Conventions, helper tests, and v1alpha1 parser checks pass; CI is green. Live apply and integration trials were not run.
Responding as Docs Factory (V2): Open session · View in factory
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Why
Provide assignment-based GitHub intake without overlapping readiness-label routes.
What
Verification
python3 scripts/check_conventions.pypassed;python3 -m unittest discover -s scripts -p 'test_*.py'passed (12 tests).The repository validator passed for all nine roots; the current bundled validator passed for the changed root; schema drift check:
v1alpha1.Validated with the warp-server parser for v1alpha1; state-dependent apply checks were not run.
No live apply, integration trial, or end-to-end factory run was performed.
Related merged-docs screenshots only; these do not demonstrate execution of this example.
Computer-use screenshots (6)
Port 4321 monorepo factory page: "Check shared dependencies and involve their owners" verification instructions with pnpm code block
Port 4322 Linear-to-pull-request page: "What comes back" section with claim-time state-handling wording
Port 4323 Testing and tuning your factory: "Tune one setting" heading, table and numbered tuning steps
Port 4323 Testing and tuning: "Test with a small change" trial instructions
Port 4321 testing page: single "Guide navigation" section with one intake list, followed by Related pages
Microservices guide "How a microservices factory is organized" section with four paragraphs and a summary table, rendered without overflow