fix: restore SPM-only setup for the example app - #44
Merged
Merged
Conversation
PR #41 reintroduced example/ios/Podfile and the Pods xcconfig includes that were removed during the Swift Package Manager migration in 1.2.1. Remove them again so the example builds via SPM, and bump to 1.2.3. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012KsJeLm3N9GSbKbdmRAWX7
The Flutter 3.44 tool adds customLLDBInitFile to the Runner scheme so debugging works on newer iOS runtimes. Committing the generated change. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012KsJeLm3N9GSbKbdmRAWX7
Building the example with Flutter 3.44 makes the migrator write builtInKotlin=false and newDsl=false into example/android/gradle.properties. Committing them keeps the build reproducible instead of leaving the file dirty after every build. Note: builtInKotlin=false keeps the example on the KGP 2.0.0 that the Flutter Gradle plugin supplies, which the build already warns about. Trying builtInKotlin=true is left for a separate change. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012KsJeLm3N9GSbKbdmRAWX7
Both CI jobs pinned Flutter 3.35.4 (Dart 3.9.2), but 1.2.2 raised the constraint to sdk ^3.12.0 / flutter >=3.44.0, so `flutter pub get` failed version solving before either build could start. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012KsJeLm3N9GSbKbdmRAWX7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR #41 (
migrate-to-built-in-kotlin) accidentally reintroduced the CocoaPods setup into the example app that had been removed during the Swift Package Manager migration in 1.2.1:example/ios/Podfilewas added backexample/ios/Flutter/Debug.xcconfigandRelease.xcconfiggot their Pods#includelines backThis removes them again so the example builds purely via SPM, and bumps the version to 1.2.3.
Changes
example/ios/Podfile#includelines fromDebug.xcconfig/Release.xcconfig1.2.2->1.2.3inpubspec.yamlandexample/pubspec.lock, with a CHANGELOG entrycustomLLDBInitFilescheme migration that the Flutter 3.44 tool writes intoRunner.xcschemeVerification
Tested on Flutter 3.44.1 / Xcode 26.1.1:
flutter build ios --simulator --no-codesignsucceeds (Built build/ios/iphonesimulator/Runner.app)Pods/directory orPodfileis generated during the buildbuild/ios/SourcePackages/checkouts/(1.9.11) and statically linked intoRunner.debug.dylibisRealDevice: false/notRealDeviceare the expected simulator results, andcydiaFoundis the usual simulator false positive — the README already notes that real-device testing is required.Not covered: only a simulator debug build was verified. A release build on a physical device has not been run.
🤖 Generated with Claude Code
https://claude.ai/code/session_012KsJeLm3N9GSbKbdmRAWX7