pose from eigen function - #25
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #25 +/- ##
==========================================
- Coverage 97.06% 96.86% -0.20%
==========================================
Files 5 5
Lines 443 447 +4
Branches 106 108 +2
==========================================
+ Hits 430 433 +3
- Misses 6 7 +1
Partials 7 7
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Andeshog
reviewed
Dec 22, 2025
Comment on lines
+158
to
+159
| return Pose{pos.x(), pos.y(), pos.z(), q.w(), q.x(), q.y(), q.z()}; | ||
| } |
Contributor
There was a problem hiding this comment.
In C++20 you can be more explicit with aggregate initialization, e.g.
return Pose{.x = pos.x(), .y = pos.y() // and so onAlso, just noticed, but change from eta to pose here either just in this PR or in a separate
|
🎉 This PR is included in version 1.7.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.