Skip to content

feat(buffer): add allocator-backed storage - #9668

Open
gatesn wants to merge 2 commits into
developfrom
ngates/buffer-allocator-core
Open

feat(buffer): add allocator-backed storage#9668
gatesn wants to merge 2 commits into
developfrom
ngates/buffer-allocator-core

Conversation

@gatesn

@gatesn gatesn commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Summary

Add allocator-backed storage to vortex-buffer.

Design: vortex-data/rfcs#65

Changes

  • Use allocator_api2 for owned buffers.
  • Keep external buffers zero-copy.
  • Preserve runtime alignment and bytes/Arrow interop.
  • Add allocator-aware constructors and tests.

API Changes

Owned buffers no longer use bytes::Bytes as storage. The bytes crate remains for interop.

@gatesn gatesn mentioned this pull request Aug 27, 2026
5 tasks
@gatesn
gatesn marked this pull request as ready for review August 27, 2026 19:24
@gatesn
gatesn requested a review from AdamGS August 27, 2026 19:24
@gatesn
gatesn force-pushed the ngates/buffer-allocator-core branch from 0f5a07e to 4911c36 Compare August 27, 2026 19:38
@codspeed-hq

codspeed-hq Bot commented Aug 27, 2026

Copy link
Copy Markdown

Merging this PR will regress 28 benchmarks

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 46 improved benchmarks
❌ 28 regressed benchmarks
✅ 2083 untouched benchmarks
⏩ 106 skipped benchmarks1
🗄️ 4 archived benchmarks run2

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation bitwise_and_vortex_buffer[1024] 5.1 µs 9.9 µs -48.41%
Simulation bitwise_and_vortex_buffer[2048] 5.5 µs 10.1 µs -45.52%
Simulation execute_scalar_struct_simple 111.4 µs 167.6 µs -33.53%
Simulation bitwise_or_vortex_buffer[128] 6.3 µs 9.4 µs -33.28%
Simulation bitwise_not_vortex_buffer[128] 6.8 µs 9.9 µs -30.92%
Simulation bitwise_and_vortex_buffer[128] 6.3 µs 8.8 µs -28.72%
Simulation collect_bool_u32_gt[1024] 11.5 µs 15.3 µs -25.2%
WallTime mul_u64_nonnull_neon 15.2 µs 19.7 µs -23.02%
Simulation runend_compress_u32 397.7 µs 500.5 µs -20.55%
Simulation compress[(10000, 4)] 496.6 µs 614.5 µs -19.18%
Simulation non_nullable[256] 257.6 µs 313.5 µs -17.83%
Simulation non_nullable[32] 262.3 µs 319 µs -17.76%
Simulation nullable[256] 258.8 µs 314.5 µs -17.71%
Simulation nullable[32] 264 µs 320.6 µs -17.66%
WallTime mul_i64_nonnull_neon 17.2 µs 20.8 µs -17.24%
Simulation bitwise_or_vortex_buffer[16384] 12.2 µs 14.4 µs -15.41%
Simulation preverify_advancing_ptr_unchecked[1000] 11.8 µs 13.8 µs -14.65%
WallTime multiply_shapes_neon[(16384, PerRowPerRow)] 17.3 µs 20.2 µs -14.52%
Simulation take_search[(0.005, 0.05)] 19.5 µs 22.5 µs -13.27%
Simulation canonicalize[256, 8] 37.8 µs 43.5 µs -13.22%
... ... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing ngates/buffer-allocator-core (94c47cb) with develop (68e2aee)

Open in CodSpeed

Footnotes

  1. 106 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

  2. 4 benchmarks were run, but are now archived. If they were deleted in another branch, consider rebasing to remove them from the report. Instead if they were added back, click here to restore them.

Signed-off-by: Nicholas Gates <nick@nickgates.com>
@gatesn
gatesn force-pushed the ngates/buffer-allocator-core branch from 4911c36 to 85d55a8 Compare August 27, 2026 21:37
Signed-off-by: Nicholas Gates <nick@nickgates.com>
@gatesn
gatesn force-pushed the ngates/buffer-allocator-core branch from 85d55a8 to 94c47cb Compare August 27, 2026 21:38
@gatesn gatesn added the changelog/feature A new feature label Aug 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/feature A new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant