[Bugfix][Router] Update average decoding duration stats - #1054
Open
dsxyy wants to merge 2 commits into
Open
Conversation
Signed-off-by: 姚远 <asmile.yy@gmail.com>
dsxyy
requested review from
ApostaC,
Shaoting-Feng,
YuhanLiu11 and
ruizhang0101
as code owners
August 25, 2026 09:24
Contributor
There was a problem hiding this comment.
Code Review
This pull request implements tracking for average decoding length statistics in RequestStatsMonitor and adds corresponding unit tests. The reviewer suggested using pop instead of get when retrieving first_token_time upon request completion to prevent potential memory leaks.
Signed-off-by: 姚远 <asmile.yy@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
decoding_length_monitorswhen a request completesRequestStats.avg_decoding_lengthdefinitionProblem
decoding_length_monitorswas initialized and read byget_request_stats(), but never updated, soavg_decoding_lengthremained-1after successfully completed requests. The existing source definition describes this value as the time from first token to completion, andfirst_token_timewas already recorded but otherwise unused.Testing
pytest -q src/tests/test_request_stats.py src/tests/test_singleton.py src/tests/test_stale_metrics.py src/tests/test_metrics.py src/tests/test_instance_failover.py src/tests/test_request_validation.py src/tests/test_transcription_streaming.py(32 passed)black --checkisort --check-onlyruff check src/tests/test_request_stats.pycodespellgit diff --check