fix(ARC-3690): remove cuepoints from flowplayer for cut fragments - #1585
Merged
bertyhell merged 1 commit intoJun 18, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to address ARC-3690 by preventing FlowPlayer cuepoints behavior from interfering with already-cut media fragments, and introduces new typing to represent media fragment metadata on files.
Changes:
- Removed the FlowPlayer
start/endprops (and associated cuepoint/start-end calculation) fromAudioOrVideoPlayer. - Extended
IeObjectFilewith amediaFragmentfield and updated fragment slider mocks accordingly. - Minor reshuffling of
IeObjectRepresentation.isMediaFragmentOfin the types file.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/modules/shared/components/AudioOrVideoPlayer/AudioOrVideoPlayer.tsx |
Removes start/end trimming logic passed into FlowPlayer (intended to eliminate cuepoint behavior for fragments). |
src/modules/ie-objects/ie-objects.types.ts |
Adds mediaFragment metadata to IeObjectFile and reorders a representation field. |
src/modules/ie-objects/components/FragmentSlider/__mocks__/fragmentSlider.tsx |
Updates mocks to satisfy the new mediaFragment field on IeObjectFile. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
reunefe
approved these changes
Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://meemoo.atlassian.net/browse/ARC-3690
before:
after:
