Feat/image svgs and async uploads [OWTR #3.1] - #551
Open
JohanHjelsethStorstad wants to merge 96 commits into
Open
Feat/image svgs and async uploads [OWTR #3.1]#551JohanHjelsethStorstad wants to merge 96 commits into
JohanHjelsethStorstad wants to merge 96 commits into
Conversation
…geUploadData for reuse
…tter reflect that they are not cms but implementation, just like /services folder does
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is PR # 3.1 in the one week till realese series. These should be merged sequentially
This PR adds support for for svgs. Now that image collections are a subservice we have the ability to require the committeelogos collection to only support svgs.
One problem that became painful in #548 was that uploading was slow and gave long prisma transactions. Now we have a separate service running in the background resizing and converting images. While this is not finished we serve a blur. Also added a new image size now that resizing does not cause time problems.