Repository navigation
Clear broken flag after successful reconnect - #154
Open
chenshi5012 wants to merge 1 commit into
Open
chenshi5012 wants to merge 1 commit into
chenshi5012 wants to merge 1 commit into
Conversation
chenshi5012
force-pushed
the
fix/reconnect-clears-broken-flag
branch
from
October 15, 2026 01:41
5d44786 to
b23c4c6
Compare
Author
|
@xiajingchun @yuhongwei380 Could you please help review this MR when you have time? Any feedback or suggestions are welcome. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number: #150
Description:
When
connectionIsBroken_is set and reconnect retries are enabled,Session::executeWithParameter( )attempts a preflight reconnect. If the reconnect succeeds, it executes the request and returns without clearingconnectionIsBroken_.As a result, subsequent requests repeatedly enter the reconnect path, causing unnecessary authentication and session ID changes even though the connection has already recovered.
How do you solve it?
Clear
connectionIsBroken_after a successful preflight reconnect and before executing the request. Subsequent requests can then reuse the recovered connection instead of reconnecting and authenticating again.Special notes for your reviewer, ex. impact of this fix, design document, etc:
SessionTest.PreflightReconnectClearsBrokenFlag.session_testsuite also passed against the local Graphd using its default no-authorization configuration.Fixes #150