refactor(llm): type provider tool choices#2737
Draft
Jordan-Jarvis wants to merge 5 commits into
Draft
Conversation
…penai-required-tool-choice-20260716
…red-tool-choice-20260716' into upstream/refactor-typed-tool-choice-20260716
Contributor
Author
|
Updated the stack to current upstream Validation on the updated head:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
str | dicttool-choice union with a canonical typed valueDependency
This is intentionally stacked on #2734 because it types the named-tool behavior introduced there. Review the final refactor commit
7a71d8c11; after #2734 lands, the base will contain the prerequisite behavior and this PR will show only the typed cutover.Validation
A broader local file-level run reached 82 passing tests; four unrelated integration/setup cases failed because the local environment had no
.envAPI key and two parallel workers timed out waiting on the shared embeddings fixture lock. The focused deterministic suite above is the authoritative change validation.