Skip to content

Remove unmaintained d2to1 during setup.#66

Open
tjni wants to merge 1 commit into
vaab:masterfrom
tjni:remove-d2to1
Open

Remove unmaintained d2to1 during setup.#66
tjni wants to merge 1 commit into
vaab:masterfrom
tjni:remove-d2to1

Conversation

@tjni

@tjni tjni commented Jul 30, 2023

Copy link
Copy Markdown

I am updating setuptools in nixpkgs to v68 and found that d2to1 does not work anymore.

Closes #60.

@sethc555

Copy link
Copy Markdown

Independent verification: with this PR checked out, python -m build (sdist → wheel) succeeds in a clean python:3.12 container with current setuptools. Without it, the published colour 0.1.5 sdist fails to build against modern setuptools (the d2to1 path crashes in get_unpatched), so pip install --no-binary :all: colour is broken today. Found while build-checking the top-5000 PyPI packages for setuptools-removal breakage — +1 for merge and release. (Note: verification needs a git checkout with tags for the autogen version machinery.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

d2to1 is deprecated

2 participants