Remove the make integration - #62
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the make integration functionality from the project. The integration attempted to provide GNU make plugin functionality but was non-functional and complicated the build process.
Key changes:
- Removed all make integration source code from
pkg/make/directory - Removed the
github.com/unmango/gnumake-godependency from Go modules - Updated the Makefile to remove make plugin build targets
Reviewed changes
Copilot reviewed 11 out of 12 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/make/mk_funcs/main.go | Deleted Go plugin loader for GNU make integration |
| pkg/make/mk_funcs/gpl.c | Deleted GPL compatibility marker required for make plugins |
| pkg/make/mk_funcs.go | Deleted make function implementations |
| pkg/make/make.go | Deleted make-related constants and types |
| go.mod | Removed github.com/unmango/gnumake-go dependency |
| go.sum | Removed checksums for the gnumake-go dependency |
| Makefile | Removed -load bin/mk_funcs.so directive and bin/mk_funcs.so build target |
| pkg/renovate/zz_generated.schema.go | Auto-generated Renovate schema updates (unrelated to make removal - appears to be from schema regeneration) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the make stuff for now. It doesn't work, and it makes the build more confusing.