Standardize .github configuration - #426
Conversation
|
👋 Hello @glenn-jocher, thank you for submitting a
For more guidance, please refer to our Contributing Guide. Don't hesitate to leave a comment if you have any questions. Thank you for contributing to Ultralytics! 🚀 |
UltralyticsAssistant
left a comment
There was a problem hiding this comment.
🔍 PR Review
Made with ❤️ by Ultralytics Actions
Reviewed both changed files. The workflow trigger standardization and removal of the duplicate Rust formatting step are consistent with the repository CI configuration. The issue template has one bounded gap: its newly advertised npm/WebGPU component is not supported by the required Rust-only environment and reproduction fields.
💬 Posted 1 inline comment
- 📝 LOW
.github/ISSUE_TEMPLATE/bug-report.yml:61SelectingWebGPU (npm)still requires Rust-specific environment details, while the required reproducible example below is a Rust CLI command. Reports for@ultralytics/yolotherefore omit the npm package version, Node/package manager, browser, WebGPU/CPU mode, and secure-context details needed to reproduce them. Add an npm/browser block to the required environment and a JavaScript example, or split the form by component.
| - Python version (e.g., 3.11.2) | ||
| - Package version (e.g., pip list | grep ultralytics) | ||
| - OS (e.g., Ubuntu 22.04, macOS 15.5, Windows 11) | ||
| - Rust toolchain (e.g., rustc --version) |
There was a problem hiding this comment.
Added an npm/browser line to the environment placeholder. The reproducible-example placeholder stays a single Rust CLI command; splitting the form by component is more than this template needs.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
| - Python version (e.g., 3.11.2) | ||
| - Package version (e.g., pip list | grep ultralytics) | ||
| - OS (e.g., Ubuntu 22.04, macOS 15.5, Windows 11) | ||
| - Rust toolchain (e.g., rustc --version) |
There was a problem hiding this comment.
Added an npm/browser line to the environment placeholder. The reproducible-example placeholder stays a single Rust CLI command; splitting the form by component is more than this template needs.
UltralyticsAssistant
left a comment
There was a problem hiding this comment.
🔍 PR Review 2
Made with ❤️ by Ultralytics Actions
Review 2: the prior issue was addressed by adding npm/browser details to the environment prompt. The workflow trigger changes, removal of the duplicate formatting steps, and updated Rust-specific issue template are consistent with the repository configuration. No new concrete issues found. LGTM.
UltralyticsAssistant
left a comment
There was a problem hiding this comment.
🔍 PR Review 3
Made with ❤️ by Ultralytics Actions
Review 3: the prior WebGPU environment finding remains addressed. The current changes standardize the Rust issue template and restrict workflow triggers to newly opened issues and pull requests targeting main. No new concrete defects were found in the changed lines. LGTM.
|
🎉 PR #426 has been merged—thank you, @glenn-jocher!
This collaboration standardizes issue reporting and formatting workflows for YOLO Rust inference, making component-specific bug reports clearer while keeping formatting checks aligned with the shared CI configuration. |
Aligns `.github/` with the reference configuration used in `ultralytics/sdk`, `skills`, `openapi` and `lite`.
🛠️ PR Summary
Made with ❤️ by Ultralytics Actions
🌟 Summary
Standardizes the repository’s GitHub issue template and formatting workflow for YOLO Rust inference by aligning them with the shared configuration used by related Ultralytics repositories.
📊 Key Changes
ultralytics-inferenceCLI command.format.ymlto run for newly opened issues and pull requests targetingmain, while removing its redundant checkout and nightlycargo fmt --checksteps already covered byci.yml.🎯 Purpose & Impact
ci.ymlon pushes and pull requests, whileformat.ymluses the shared workflow trigger configuration.