Skip to content

🐛 Line brem profile bug#4219

Draft
chris-ashe wants to merge 13 commits into
mainfrom
line_brem_profile_bug
Draft

🐛 Line brem profile bug#4219
chris-ashe wants to merge 13 commits into
mainfrom
line_brem_profile_bug

Conversation

@chris-ashe

Copy link
Copy Markdown
Collaborator

Description

Checklist

I confirm that I have completed the following checks:

  • My changes follow the PROCESS style guide
  • I have justified any large differences in the regression tests caused by this pull request in the comments.
  • I have added new tests where appropriate for the changes I have made.
  • If I have had to change any existing unit or integration tests, I have justified this change in the pull request comments.
  • If I have made documentation changes, I have checked they render correctly.
  • I have added documentation for my change, if appropriate.

@chris-ashe chris-ashe added Radiation Plasma radiated power Bug Something isnt working labels May 5, 2026
@codecov-commenter

codecov-commenter commented May 5, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 55.88235% with 15 lines in your changes missing coverage. Please review.
✅ Project coverage is 48.85%. Comparing base (d587ca8) to head (e4e975a).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
process/models/physics/impurity_radiation.py 56.25% 14 Missing ⚠️
process/models/physics/physics.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4219      +/-   ##
==========================================
- Coverage   48.86%   48.85%   -0.01%     
==========================================
  Files         151      151              
  Lines       29461    29468       +7     
==========================================
+ Hits        14397    14398       +1     
- Misses      15064    15070       +6     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@chris-ashe chris-ashe force-pushed the line_brem_profile_bug branch from 439cbc9 to 4c7c3ce Compare May 28, 2026 14:09
chris-ashe and others added 13 commits June 17, 2026 11:17
…nd improve comments

Co-authored-by: Copilot <copilot@github.com>
…n imprad_profile method

Co-authored-by: Copilot <copilot@github.com>
… accuracy in parameter types and documentation

Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
…mathematical notation

Co-authored-by: Copilot <copilot@github.com>
…ions

Co-authored-by: Copilot <copilot@github.com>
@chris-ashe chris-ashe force-pushed the line_brem_profile_bug branch from 03ddd71 to e4e975a Compare June 17, 2026 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Something isnt working Radiation Plasma radiated power

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐛 Incorrect calculation of line and Bremsstrahlung plasma radiation components

2 participants