Skip to content

feat: resolve noSchematicRepresentation support for Normal Component - #3160

Merged
seveibar merged 8 commits into
tscircuit:mainfrom
ArnavK-09:pushbutton
Aug 12, 2026
Merged

feat: resolve noSchematicRepresentation support for Normal Component#3160
seveibar merged 8 commits into
tscircuit:mainfrom
ArnavK-09:pushbutton

Conversation

@ArnavK-09

Copy link
Copy Markdown
Contributor

fix #3117

because it inherits ChipProps
so prop is doc-ed

@vercel

vercel Bot commented Aug 11, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
tscircuit-core-benchmarks Ready Ready Preview Aug 12, 2026 10:22am

Request Review

@ArnavK-09 ArnavK-09 changed the title feat: add noSchematicRepresentation support to pushButton component feat: resolve noSchematicRepresentation support to pushButton component Aug 11, 2026
@ArnavK-09 ArnavK-09 changed the title feat: resolve noSchematicRepresentation support to pushButton component feat: resolve noSchematicRepresentation support for <pushbutton /> Aug 11, 2026

@seveibar seveibar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should probably be in NormalComponent, idk why it would be a push button specific thing

@seveibar

Copy link
Copy Markdown
Contributor

waiting for tests to pass before reviewing because idk if this will have negative effects

@ArnavK-09 ArnavK-09 changed the title feat: resolve noSchematicRepresentation support for <pushbutton /> feat: resolve noSchematicRepresentation support for Normal Component Aug 12, 2026
@seveibar
seveibar merged commit 799859d into tscircuit:main Aug 12, 2026
17 checks passed
@tscircuitbot

Copy link
Copy Markdown
Contributor

Thank you for your contribution! 🎉

PR Rating: ⭐⭐
Impact: Minor

Track your contributions and see the leaderboard at: tscircuit Contribution Tracker


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

pushbutton: noSchematicRepresentation is ignored

3 participants