Repository navigation
feat: add allow-forked-pr-uploads input - #148
Merged
Merged
Conversation
Forwards --allow-forked-pr-uploads (analytics-cli >= 0.15.5-beta.3) and accepts it in place of a token or public repo id, so a forked pull_request run can upload against a test collection that has opted in.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Exposes the CLI's
--allow-forked-pr-uploads(analytics-cli#1205, shipped in 0.15.5-beta.3) as an action input.allow-forked-pr-uploads: trueforwards the bare flag to the CLIvalidateInputsaccepts it as the third alternative totoken/public-repo-id; without it the action rejected the step withMissing organization token or public repo idbefore the CLI ever ran, so settingTRUNK_ALLOW_FORKED_PR_UPLOADSin the step env was not enoughdist/index.jsrebuilt withpnpm buildThe CLI still owns the
--test-collection-idrequirement and errors at arg-parse time, so the action does not duplicate that check.Test plan
pnpm test: 53 passed, including new cases forvalidateInputsandgetArgspnpm build,trunk checkon changed filescli-version: 0.15.5-beta.3and collection5fheimOf🤖 Generated with Claude Code