Repository navigation
docs: describe swift-test-xunit-paths as taking globs - #147
Merged
Merged
Conversation
The input said "Takes files, not glob paths", which was true of the CLI argument it forwards to until trunk-io/analytics-cli#1201 gave that argument the same expansion `--junit-paths` has always had. Worded to match the `junit-paths` row above it, since the two now behave the same way. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
dfrankland
requested review from
TylerJang27,
acatxnamedvirtue and
max-trunk
September 15, 2026 04:37
max-trunk
approved these changes
Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both the README row and the
action.yamldescription said the input "Takes files, not glob paths". That was accurate: the CLI argument this forwards to opened each comma-split value directly, so a pattern failed withfailed to open ./junit*.xml.trunk-io/analytics-cli#1201 gives
--swift-test-xunit-pathsthe same expansion--junit-pathshas always had, including the canonical-path dedupe, so the sentence stops being true once that ships. Reworded to match thejunit-pathsrow above it, since the two now behave the same way.Merge after the CLI change is in a release.
cli-versiondefaults tolatest, so until 0.15.5 ships this would document a capability users don't have — a glob would still reachFile::openverbatim and fail.Testing
No source change — only the input description in
action.yamland its README row, neither of which is asserted anywhere in__tests__. I ranpnpm buildanyway anddist/index.jscame out byte-identical, which is the pre-commit hook's whole job; it can't run in this environment (nopnpminside trunk's sandbox), so the commit is--no-verifywith that check done by hand instead. The README diff is larger than the one line it changes because prettier re-pads the whole table.🤖 Generated with Claude Code