docs(metrics): add metrics introduced in GreatVoyage-v4.8.2 - #124
Conversation
| - `tron:block_push_latency_seconds_sum`: Total sum of all observed values | ||
|
|
||
| Used to monitor the distribution of transaction counts in blocks pushed to the node, grouped by the block producer's Base58Check address in the `miner` label: | ||
| - `tron:block_transaction_count_bucket`: Cumulative number of observed block pushes whose transaction count is less than or equal to the `le` value |
There was a problem hiding this comment.
Consider documenting the fixed bucket boundaries of this histogram. In java-tron (GreatVoyage-v4.8.2), tron:block_transaction_count is registered with explicit buckets {0, 20, 50, 80, 100, 120, 140, 160, 180, 200, 230, 260, 300, 500, 2000, 5000, 10000} (MetricsHistogram.java). Without the le values listed here, operators have to query /metrics on a live node to interpret the _bucket series or build Grafana panels. Suggest adding a line like: "Buckets: 0, 20, 50, 80, 100, 120, 140, 160, 180, 200, 230, 260, 300, 500, 2000, 5000, 10000." Not blocking — nice-to-have.
There was a problem hiding this comment.
I initially wrote this, but later removed it to keep the descriptions consistent with other metrics.
warku123
left a comment
warku123
left a comment
There was a problem hiding this comment.
LGTM. Verified both metrics against java-tron GreatVoyage-v4.8.2 source: names, labels (action/witness/miner), Base58Check address format, increment/observe sites (MaintenanceManager.applyBlock, Manager.pushBlock) all match. Docs-only, no risk. Approving — the bucket-boundary note is a nice-to-have; keeping style consistent with other metrics is a fair call.
3 participants
Summary
minerlabelWhy
The All Metrics reference did not include the Prometheus metrics introduced in GreatVoyage-v4.8.2 for SR-set changes and per-block transaction counts.
Impact
Operators can identify and interpret these metrics when querying java-tron or building Grafana panels. This documentation-only change does not affect runtime configuration or dashboard behavior.
Validation
git diff --check