Fix repo hygiene, CI publishing, and healthcheck coverage - #34
Merged
Conversation
- Split garbled .gitignore pattern "quakejsdocs" into quakejs/docs - Add *.cfg eol=lf rule and normalize server.cfg line endings - Push image to Docker Hub from CI on master (PRs still build-only); requires DOCKERHUB_USERNAME/DOCKERHUB_TOKEN repo secrets - Extend healthcheck to also verify the game server accepts TCP connections on 27960 (via bash, since CMD-SHELL runs under dash) - Document HTTP_PORT semantics in README Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
quakejsdocs(missing newline since creation) intoquakejsanddocs, so a local quakejs clone from the README's non-Docker instructions is actually ignored.*.cfg text eol=lfand normalizeserver.cfgline endings, so the one config file COPY'd into the image no longer varies by checkout platform.treyyoder/quakejs:lateston pushes to master/main viadocker/build-push-action; pull requests remain build-only. The previously-unused Buildx setup step is now actually used.bash -cbecauseHEALTHCHECKshell-form commands run under/bin/sh(dash) at runtime — the DockerfileSHELLinstruction does not apply — and dash lacks bash's/dev/tcp.HTTP_PORTis the host-side port baked into the client page and must match the port mapping.Before merging
Add repository secrets
DOCKERHUB_USERNAMEandDOCKERHUB_TOKEN(Docker Hub access token, read/write). Without them the push step fails on the first master build. Note: the currentlateston Docker Hub dates from 2022-08-30 — the first successful merge will replace it.Testing
Built the image locally and ran a container: HTTP 200,
index.htmlhost/port rewrite verified, game port accepting connections, and Docker's healthcheck reportshealthy. The pre-fix/dev/tcphealthcheck was confirmed failing (exit 2 under dash) before thebash -cwrapper fixed it.🤖 Generated with Claude Code