Exec tests: leave the temp folder before deleting it - #8
Merged
Conversation
A CShell's CurrentFolder setter assigns Environment.CurrentDirectory, which is process-wide, so the three Exec tests that start a shell in the temp folder left the whole test run standing in it. Cleanup then deleted it. On Linux the delete succeeds, and every later `new CShell()` throws FileNotFoundException from getcwd() on a directory that is no longer there -- four tests down, which is what red-lit the build on main. On Windows the OS refuses to delete a directory that is someone's cwd, the bare catch swallowed it, and the folders piled up in %TEMP% instead. Same bug, two symptoms, and only one of them visible where the tests are usually run. Restore the starting directory before deleting. Verified both ways: the failure reproduces on Ubuntu 24.04 (4 failed) and passes with this change (315/315), and on Windows the temp folders are now actually cleaned up. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vga8G5aDrA2qYn8BSCgTsd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A CShell's CurrentFolder setter assigns Environment.CurrentDirectory, which is process-wide, so the three Exec tests that start a shell in the temp folder left the whole test run standing in it. Cleanup then deleted it.
On Linux the delete succeeds, and every later
new CShell()throws FileNotFoundException from getcwd() on a directory that is no longer there -- four tests down, which is what red-lit the build on main. On Windows the OS refuses to delete a directory that is someone's cwd, the bare catch swallowed it, and the folders piled up in %TEMP% instead. Same bug, two symptoms, and only one of them visible where the tests are usually run.Restore the starting directory before deleting. Verified both ways: the failure reproduces on Ubuntu 24.04 (4 failed) and passes with this change (315/315), and on Windows the temp folders are now actually cleaned up.
Claude-Session: https://claude.ai/code/session_01Vga8G5aDrA2qYn8BSCgTsd