Repository navigation
fix(examples): keep dashboard cards and panel in step in assistant-ui-dashboards - #1595
Open
AbhinRustagi wants to merge 4 commits into
Open
AbhinRustagi wants to merge 4 commits into
AbhinRustagi wants to merge 4 commits into
Conversation
…-dashboards - The card reads the dashboard's stream, so it says Generating or Changing while the panel does and Couldn't load after a failure, not Live - Switching chats or starting a new one closes the panel; cards in a reopened chat no longer open it by themselves - Picking a dashboard in the Dashboards tab switches to the chat that built it - The Next dev badge moves to the bottom-right and the list gets bottom padding, so Show more isn't covered
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
…the list The card compared the panel only with its own tool call, so a dashboard opened from the Dashboards tab left its card saying Open. It now also matches the list's key for the same dashboard.
…d of a generic one
…ross an edit (#1599) Two fixes to editing in assistant-ui-dashboards. An edit went to the latest dashboard in the thread, not the one open beside the chat: the chat route only received the messages, so the model could not know which dashboard the user was looking at. Each chat request now carries the open dashboard's artifact id, the route validates it and names it in the system prompt, and the prompt reads "it", "this" or "the dashboard" as the open one when there is one. A dashboard opened from the list beside a new chat can now be edited too. Every edit rebuilt the panel, which reset its filters and scroll position: the edit's card reopened the panel under its own tool call id, and the panel is keyed by that. An edit to the dashboard already in the panel now leaves it mounted; it follows the edit through the stream it shares with the card. All of a dashboard's cards read as open while the panel shows it. Co-authored-by: Claude Fable 5.2 <noreply@anthropic.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes from QA on the assistant-ui dashboards example:
The card follows the dashboard's own stream, so it says "Generating" while the panel does and "Couldn't load" after a failure, instead of "Live" straight away
Switching chats or hitting New Chat closes the panel, and cards in a reopened chat don't pop it open again
Picking a dashboard in the Dashboards tab now jumps to the chat that built it, and its card there shows "Close" since it's the one open
"Show more" is no longer hidden behind the Next dev badge
When the backend fails, the chat shows the gateway's error in a few seconds, instead of "An error occurred." after ~30s of retries